New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome no longer supports caretPositionFromPoint #1909

Merged
merged 3 commits into from May 31, 2018

Conversation

Projects
None yet
4 participants
@herstand
Contributor

herstand commented Apr 23, 2018

Attempting to run document.caretPositionFromPoint in Chrome 65.0x gives the error "Uncaught TypeError: document.caretPositionFromPoint is not a function"

Chrome no longer supports caretPositionFromPoint
Attempting to run document.caretPositionFromPoint in Chrome 65.0x gives the error "Uncaught TypeError: document.caretPositionFromPoint is not a function"
@@ -314,6 +314,7 @@
},
"chrome": {
"version_added": "53"
,"version_removed" : "65"

This comment has been minimized.

@connorshea

connorshea Apr 23, 2018

Contributor

The comma should be on the line above

This comment has been minimized.

@connorshea

connorshea Apr 23, 2018

Contributor

Also this shouldn't have a space before the colon.

This comment has been minimized.

@herstand

herstand Apr 23, 2018

Contributor

Using leading commas creates cleaner diffs. It makes clear that only one line has been edited, not two.

This comment has been minimized.

@connorshea

connorshea Apr 23, 2018

Contributor

Regardless it will cause the Travis build to fail

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 26, 2018

@jpmedley Can you verify or disprove the removal of this API?

@jpmedley

This comment has been minimized.

Contributor

jpmedley commented Apr 26, 2018

I don't believe it was ever implemented to begin with. It is nowhere in the git history of DocumentOrShadowRoot.

@Elchi3

Elchi3 approved these changes May 31, 2018

Thanks, changed to false for Chromium browsers then.

@Elchi3 Elchi3 merged commit 115ebb9 into mdn:master May 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

a2sheppy added a commit to a2sheppy/browser-compat-data that referenced this pull request Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment