New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source element and its attributes for Safari desktop/iOS #1964

Merged
merged 5 commits into from May 2, 2018

Conversation

Projects
None yet
3 participants
@Josh68
Contributor

Josh68 commented Apr 30, 2018

Apple developer guide and caniuse suggest that the <source> element and srcset, sizes, media, src, and type attributes are all supported by iOS Safari by v9.2 and desktop Safari by v9.

Update source element and its attributes for iOS.
[Apple developer guide](https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/HTMLTags.html#//apple_ref/doc/uid/30001262-SW5) and [caniuse](https://caniuse.com/#feat=srcset) suggest that the `<source>` element and `srcset`, `sizes`, `media`, `src`, and `type` attributes are all supported by iOS, fully by v9.2. I do not know how to correctly add the metadata for partial support of `srcset` and `sizes` in v8. Thanks.
@@ -164,7 +164,7 @@
"version_added": null

This comment has been minimized.

@ExE-Boss

ExE-Boss May 1, 2018

Contributor

This should be:

"safari": [
  {
    "version_added": "9.2"
  },
  {
    "version_added": "8",
    "partial_implementation": true
  }
]
@@ -288,7 +288,7 @@
"version_added": null

This comment has been minimized.

@ExE-Boss

ExE-Boss May 1, 2018

Contributor
@@ -164,7 +164,7 @@
"version_added": null
},
"safari_ios": {
"version_added": null
"version_added": "9.2"

This comment has been minimized.

@ExE-Boss

ExE-Boss May 1, 2018

Contributor

This should be:

"safari_ios": [
  {
    "version_added": "9.2"
  },
  {
    "version_added": "8",
    "partial_implementation": true
  }
]
@@ -288,7 +288,7 @@
"version_added": null
},
"safari_ios": {
"version_added": null
"version_added": "9.2"

This comment has been minimized.

@ExE-Boss

ExE-Boss May 1, 2018

Contributor

This comment has been minimized.

@Josh68

Josh68 May 1, 2018

Contributor

Thanks. Looks good. I didn't quite know the correct format for everything.

@Josh68

Adding partial implementations

Fixing messed up JSON
Not paying good attention in initial edit. This is valid
@Josh68

Fixing JSON formatting

@ExE-Boss

This comment has been minimized.

Contributor

ExE-Boss commented May 1, 2018

Can you now duplicate the changes I requested to desktop Safari?

@Josh68

This comment has been minimized.

Contributor

Josh68 commented May 1, 2018

My PR was aimed at iOS, as it says in the title. Feel free to do another PR to update desktop. Something's also not right if I'm just relying on caniuse.com to update these tables on MDN. The version for the partial introduction of srcset/sizes on desktop Safari, according to them, is 7, and full support came in 9, not 9.2, as on iOS. Again, if I trust caniuse. I really don't know how either source is verifying this data. I assume somehow scraping changelogs, but then why is MDN not in sync?

EDIT: Went ahead and added Safari desktop details for srcset and sizes directly from caniuse. How should MDN actually stay up-to-date, without having PRs from what people find there?

Expanding PR
Updating `srcset` and `sizes` support for desktop Safari, pulled from [caniuse](https://caniuse.com)
@Josh68

Adding srcset and sizes support for Safari desktop from caniuse

@Josh68 Josh68 changed the title from Update source element and its attributes for iOS. to Update source element and its attributes for Safari desktop/iOS May 1, 2018

Fix version per Travis' allowed Safari versions
"7.1" fails CI, so changing to "7"
@Josh68

Safari version "7.1" fails Travis CI, so changing to "7"

@ExE-Boss

LGTM, r+

@Elchi3

Elchi3 approved these changes May 2, 2018

Thank you! 👍

@Elchi3 Elchi3 merged commit 103594a into mdn:master May 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Josh68 Josh68 deleted the Josh68:patch-1 branch May 2, 2018

@Josh68

This comment has been minimized.

Contributor

Josh68 commented May 2, 2018

Thanks, @Elchi3 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment