New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding compat data for css at-rules media any-hover #1977

Merged
merged 2 commits into from May 23, 2018

Conversation

Projects
None yet
3 participants

@Elchi3 Elchi3 added the data:css 🎨 label May 7, 2018

@ExE-Boss ExE-Boss referenced this pull request May 14, 2018

Closed

Migrate remaining CSS @media pages #2009

25 of 30 tasks complete
@ddbeck

Thanks for this PR, @nathancharles! This looks pretty good. I had a couple of comments on this and I learned a little more about any-hover, so I've suggested some additions to the data that weren't in the original table. Let me know if you have any questions. Thanks again!

},
"safari": {
"version_added": "9",
"notes": "Implemented in <a href='https://bugs.webkit.org/show_bug.cgi?id=134822' rel='noopener'>WebKit bug #134822</a>."

This comment has been minimized.

@ddbeck

ddbeck May 16, 2018

Collaborator

Would you mind removing this note? Generally, notes that are about historical bugs (i.e., features that have shipped and don't have any known caveats) don't need to be migrated.

"description": "<code>any-hover</code> media feature",
"support": {
"webview_android": {
"version_added": false

This comment has been minimized.

@ddbeck

ddbeck May 16, 2018

Collaborator

I did a little digging and it looks like Android Webview, Chrome, and Chrome for Android all shipped this in version 41. Would you mind updating all three values?

"version_added": "28"
},
"opera_android": {
"version_added": null

This comment has been minimized.

@ddbeck

ddbeck May 16, 2018

Collaborator

This is also 28.

},
"firefox": {
"version_added": false,
"notes": "<a href='https://bugzil.la/1035774' rel='noopener'>bug 1035774 – Implement Interaction Media Features including pointer:coarse that replaces non-standard -moz-touch-enabled</a>"

This comment has been minimized.

@ddbeck

ddbeck May 16, 2018

Collaborator

For this note and the one below, it's probably best to replace it with something like "See <a href='https://bugzil.la/1035774'>bug 1035774</a>." Bug titles can and do change, after all, so this is one less thing to go out of date.

"notes": "<a href='https://bugzil.la/1035774' rel='noopener'>bug 1035774 – Implement Interaction Media Features including pointer:coarse that replaces non-standard -moz-touch-enabled</a>"
},
"ie": {
"version_added": null

This comment has been minimized.

@ddbeck

ddbeck May 16, 2018

Collaborator

This is false.

"version_added": "16"
},
"edge_mobile": {
"version_added": null

This comment has been minimized.

@ddbeck

ddbeck May 16, 2018

Collaborator

This is the same as edge, 16.

@Elchi3 Elchi3 added this to the Q2 Sprint 3 milestone May 16, 2018

@Elchi3

This comment has been minimized.

Member

Elchi3 commented May 23, 2018

Hey @nathancharles, I've addressed Daniel's review comments for you. Thanks for your contribution!

@ddbeck does this look good now?

@ddbeck

This comment has been minimized.

Collaborator

ddbeck commented May 23, 2018

Yep, looks good! Thank you @Elchi3! I'll merge it now.

@ddbeck ddbeck merged commit c9158ec into mdn:master May 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nathancharles

This comment has been minimized.

Contributor

nathancharles commented Jun 9, 2018

Thanks @Elchi3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment