New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MDN page for chrome support of AnimationEvent.pseudoElement #1986

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
4 participants
@xidachen
Contributor

xidachen commented May 7, 2018

The AnimationEvent.pseudoElement is implemented and shipped in chromium here:
https://chromium-review.googlesource.com/c/chromium/src/+/1019383

It will hit chrome stable in M68. This updates the MDN page.

@birtles @flackr

@Elchi3 Elchi3 added the data:api 🐇 label May 7, 2018

@@ -338,13 +338,13 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/AnimationEvent/pseudoElement",
"support": {
"webview_android": {
"version_added": false
"version_added": "68"

This comment has been minimized.

@ExE-Boss

ExE-Boss May 7, 2018

Contributor

It might be a good idea to move webview_android to the end of the support block (see issue #398 and PR #1882)

This comment has been minimized.

@xidachen

xidachen May 7, 2018

Contributor

Should I move webview_android only for the 'pseudoElement', or everything in this file?

This comment has been minimized.

@connorshea

connorshea May 18, 2018

Contributor

I think the plan is to alphabetize everything once the PR queue has been gone-through, so you don't need to worry about that for now.

@connorshea

This comment has been minimized.

Contributor

connorshea commented May 18, 2018

LGTM 👍

@Elchi3

Elchi3 approved these changes May 22, 2018

LGTM as well, thanks!

You might want to update https://www.chromestatus.com/features/5112855204462592 as well.

@Elchi3 Elchi3 merged commit 76ca04d into mdn:master May 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment