Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for Window sub features from A to F #2109

Merged
merged 12 commits into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@keshavmesta
Copy link
Contributor

commented May 22, 2018

As discussed in #2011

@Elchi3 Elchi3 added this to the Q2 Sprint 3 milestone May 22, 2018

@wbamberg wbamberg self-requested a review May 23, 2018

@wbamberg

This comment has been minimized.

Copy link
Member

commented May 31, 2018

Thanks @keshavmesta !

It looks to me as if this is missing some items. It includes data for the following:

cancelIdleCallback
clearImmediate
close
convertPointFromNodeToPage
convertPointFromPageToNode
crypto
customElements
devicePixelRatio
dialogArguments
event
frameElement
fullScreen

Looking at the sidebar for Window, I see these properties:

applicationCache
caches*
closed
console
controllers
crypto
customElements
defaultStatus
devicePixelRatio
dialogArguments
directories
document
frameElement
frames
fullScreen

...and these methods:

alert()
atob()*
back()
blur()
btoa()*
cancelAnimationFrame()
cancelIdleCallback()
captureEvents()
clearImmediate()
clearInterval()*
clearTimeout()*
close()
confirm()
convertPointFromNodeToPage()
convertPointFromPageToNode
createImageBitmap()*
dump()
event
fetch()*
find()
focus()
forward()

The ones I put an asterisk * by are part of the WindowOrWorkerGlobalScope interface, so (as I understand it) they are to be omitted from the Window data. But I'm not sure why the rest are missing.

@keshavmesta

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2018

@wbamberg yes there is no compat data available for the skipped ones on MDN.

@wbamberg

This comment has been minimized.

Copy link
Member

commented Jun 3, 2018

Thanks for the clarification @keshavmesta :)

@wbamberg
Copy link
Member

left a comment

Thanks @keshavmesta ! A few comments, but they're all pretty minor :).

},
"ie": {
"version_added": true,
"notes": "This method is currently only proposed, is not expected to become standard, and is only implemented by recent builds of Internet Explorer."

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 4, 2018

Member

We should omit this note, since we can capture the same information more effectively by marking it nonstandard in the data.

},
"status": {
"experimental": false,
"standard_track": true,

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 4, 2018

Member

We should make this false (i.e. it is not standard)

"version_added": true
},
"firefox": {
"version_added": true

This comment has been minimized.

Copy link
@wbamberg
"opera_android": {
"version_added": null
},
"safari": {

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 4, 2018

Member

This also omits a note saying that the Safari version is prefixed - we should capure this, but using prefix not a note.

That note also refers to IE, including a link that now redirects to the MDN page :). We should just scrap that part of the note.

"version_added": null
},
"safari": {
"version_added": true

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 4, 2018

Member

Same issue as above for convertPointFromNodeToPage.

},
"safari": {
"version_added": "4",
"notes": "?"

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 4, 2018

Member

Same comment here, omit this.

},
"firefox": {
"version_added": "1",
"notes": "1.7 or earlier"

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 4, 2018

Member

Same comment here, omit this. Use "1" or true.

},
"firefox_android": {
"version_added": true,
"notes": "1.7 or earlier"

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 4, 2018

Member

Again, omit this.

},
"status": {
"experimental": false,
"standard_track": true,

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 4, 2018

Member

This is not standard according to the page "window.fullScreen is not part of any W3C specification or technical recommendation.".

@@ -2595,4 +3112,4 @@
}
}
}
}
}

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 4, 2018

Member

Files should end with a newline.

@wbamberg

This comment has been minimized.

Copy link
Member

commented Jun 21, 2018

I've pushed a commit that (I hope) addresses the review comments I had for this PR. I don't know if it needs an extra review go-round or not :).

@Elchi3

Elchi3 approved these changes Jun 27, 2018

Copy link
Member

left a comment

This looks good to me now. Thanks @keshavmesta and @wbamberg 👍

@Elchi3 Elchi3 merged commit bc5c607 into mdn:master Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@keshavmesta

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2018

Thanks @wbamberg for taking care of those review comments 👍

gsouquet added a commit to gsouquet/browser-compat-data that referenced this pull request Jun 29, 2018

Merge branch 'master' into positionoptions
* master: (175 commits)
  Add Server-Timing header (mdn#2148)
  40th alpha version
  Add compat data for input-password (mdn#2235)
  Add addTransceiver() method for RTCPeerConnection. (mdn#2311)
  Update Payments API for Chrome. (mdn#2378)
  Add compat data for MutationObserver (mdn#2094)
  Fix compat data for "let" in Chrome (mdn#1632)
  Safari has more formdata support now (mdn#2376)
  Add compat data for Window sub features from A to F (mdn#2109)
  Add guidelines around worker support and constructors for API subfeatures (mdn#2373)
  Update place-content.json (mdn#2240)
  Add compat data for HTMLDetailsElement (mdn#2315)
  Add compat data for input-month (mdn#2204)
  Add compat data to input-week (mdn#2230)
  Add compat data for input-radio (mdn#2208)
  Add compat data for input-tel (mdn#2226)
  Add compat data for input-image (mdn#2207)
  Add compat data for input-number (mdn#2206)
  Add compat data for input-hidden (mdn#2203)
  Add compat data for input-file (mdn#2202)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.