New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility data for AudioNodeOptions #2160

Merged
merged 1 commit into from May 31, 2018

Conversation

Projects
None yet
3 participants
@haykam821
Contributor

haykam821 commented May 25, 2018

There is not a column for Edge in the original table so I did not add a field for Edge in the new compatibility table here.

Also, there is both an Android and Android Webview column but only one browser identifier (webview_android), so I only put the data for the Android Webview column:
Android and Android Webview columns

@maboa

maboa approved these changes May 30, 2018

This all looks great - thanks :) For future reference, usually if Edge data is not included in the original table we add it but as null to represent the fact that we don't know its compatibility.

ie

         "edge": {
            "version_added": null
          },
          "edge_mobile": {
            "version_added": null
          },
@Elchi3

Elchi3 approved these changes May 31, 2018

Thanks for the PR @haykam821 and thanks for the review @maboa 👍

@Elchi3 Elchi3 merged commit 1df8c73 into mdn:master May 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@haykam821 haykam821 deleted the haykam821:audionodeoptions-compat-data branch May 31, 2018

a2sheppy added a commit to a2sheppy/browser-compat-data that referenced this pull request Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment