Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for input-datetime-local #2200

Merged
merged 2 commits into from Jun 24, 2018

Conversation

Projects
None yet
3 participants
@wbamberg
Copy link
Member

left a comment

Looks good @maboa , just a couple of comments.

"elements": {
"input": {
"input-datetime-local": {
"__compat": {

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 21, 2018

Member

As before, I think this needs:

"description": "<code>type=\"datetime-local\"</code>"
},
"firefox": {
"version_added": false,
"notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a> and <a href='https://wiki.mozilla.org/TPE_DOM/Date_time_input_types'>TPE DOM/Date time input types</a>."

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 21, 2018

Member

I would omit "This feature is not implemented yet." as it is redundant. Also the project page link doesn't seem very active, it's probably better to just link to the bug:

"See <a href='https://bugzil.la/888320'>bug 888320</a>."
},
"safari": {
"version_added": false,
"notes": "It is recognized but there is no UI."

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 21, 2018

Member

Oh, and I agree with Daniel's comment on this.

@wbamberg
Copy link
Member

left a comment

Sorry, this comment was on the wrong PR and GitHub won't let me delete it...

@maboa

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2018

Made the changes as requested. Thanks!

@wbamberg
Copy link
Member

left a comment

Thanks @maboa !

@wbamberg wbamberg merged commit 0f30606 into mdn:master Jun 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.