Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for input-month #2204

Merged
merged 2 commits into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@wbamberg
Copy link
Member

left a comment

Thanks Mark! A few suggestions for changes to notes that you've seen before, and the usual comment about a description.

"elements": {
"input": {
"input-month": {
"__compat": {

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 21, 2018

Member

As for the others:

           "description": "<code>type=\"month\"</code>"
},
"firefox": {
"version_added": false,
"notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a> and <a href='https://wiki.mozilla.org/TPE_DOM/Date_time_input_types'>TPE DOM/Date time input types</a>."

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 21, 2018

Member

Same comment as #2200 (comment)

"notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a> and <a href='https://wiki.mozilla.org/TPE_DOM/Date_time_input_types'>TPE DOM/Date time input types</a>."
},
"firefox_android": {
"version_added": "4"

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 21, 2018

Member

It's unlikely Firefox for Android supports this, if Firefox Desktop doesn't.

},
"safari": {
"version_added": false,
"notes": "It is recognized but there is no UI."

This comment has been minimized.

Copy link
@wbamberg

wbamberg Jun 21, 2018

Member

Again I agree with Daniel's comment #2199 (comment).

Comments addressed

@Elchi3

Elchi3 approved these changes Jun 27, 2018

Copy link
Member

left a comment

Thanks Mark and Will! 👍

@Elchi3 Elchi3 merged commit 082ff83 into mdn:master Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

gsouquet added a commit to gsouquet/browser-compat-data that referenced this pull request Jun 29, 2018

Merge branch 'master' into positionoptions
* master: (175 commits)
  Add Server-Timing header (mdn#2148)
  40th alpha version
  Add compat data for input-password (mdn#2235)
  Add addTransceiver() method for RTCPeerConnection. (mdn#2311)
  Update Payments API for Chrome. (mdn#2378)
  Add compat data for MutationObserver (mdn#2094)
  Fix compat data for "let" in Chrome (mdn#1632)
  Safari has more formdata support now (mdn#2376)
  Add compat data for Window sub features from A to F (mdn#2109)
  Add guidelines around worker support and constructors for API subfeatures (mdn#2373)
  Update place-content.json (mdn#2240)
  Add compat data for HTMLDetailsElement (mdn#2315)
  Add compat data for input-month (mdn#2204)
  Add compat data to input-week (mdn#2230)
  Add compat data for input-radio (mdn#2208)
  Add compat data for input-tel (mdn#2226)
  Add compat data for input-image (mdn#2207)
  Add compat data for input-number (mdn#2206)
  Add compat data for input-hidden (mdn#2203)
  Add compat data for input-file (mdn#2202)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.