Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect-ratio supported in Chrome #2224

Merged
merged 2 commits into from Jun 12, 2018
Merged

Aspect-ratio supported in Chrome #2224

merged 2 commits into from Jun 12, 2018

Conversation

FilipChalupa
Copy link
Contributor

No description provided.

@Elchi3 Elchi3 added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jun 7, 2018
@ddbeck
Copy link
Collaborator

ddbeck commented Jun 9, 2018

Hi @onset, thank you for starting this PR. Do you have any more information about this new support (I couldn't find any details about it on own)? It maybe possible to update Android or WebView data, while we're at it.

@FilipChalupa
Copy link
Contributor Author

FilipChalupa commented Jun 10, 2018

Hi @ddbeck, I've had trouble finding any support information in release notes of browsers so I've made a small pen to test the aspect-ratio, min-aspect-ratio and max-aspect-ratio. https://codepen.io/Onset/full/dKNgmG/

I'm happy to know now that aspect ratio is supported in all latest browsers.

Details

Google Chrome 67

image

Safari 9.1

image

MS Edge 17

image

IE 11

image

Firefox 60

image

Opera 53

image

Samsung Internet 6.4

image

UC Browser

image

Google Chrome 51 inside Facebook Messenger

image

@paulirish
Copy link
Contributor

afaik it's "always" been supported in chrome: https://chromium.googlesource.com/chromium/src/+/64c713c8f749364f758d3fcc5648fe12686425fd

i can't see that this was even disabled by default.

@paulirish
Copy link
Contributor

paulirish commented Jun 12, 2018

fwiw. here's one way to try tracking down this info for chrome, if chromestatus.com doesn't have the answer..

  1. open https://cs.chromium.org/
  2. try searching for a useful string like max-aspect-ratio
  3. choose a useful file. we'll go with the top one: mq-aspect-ratio.html
  4. in the top right open View > Git revision Log. (Sometimes Git Blame is slightly more useful)
    image

This hopefully should reveal some commits which point to where a feature was added or flipped on.

@FilipChalupa
Copy link
Contributor Author

@paulirish Valuable tool! Thank you for the links and step by step guide.

I'm not sure which version to attribute though.

@paulirish
Copy link
Contributor

I'm not sure which version to attribute though.

either Chrome 4 or Chrome 5.
:)

@FilipChalupa
Copy link
Contributor Author

Now I see the version is not required and "version_added": true works just fine. But still, thank you.

@ddbeck
Copy link
Collaborator

ddbeck commented Jun 12, 2018

Thank you for the update, @onset and thank you, @paulirish, for the lesson in searching Chrome's history!

@ddbeck ddbeck merged commit 0ef96c6 into mdn:master Jun 12, 2018
@FilipChalupa FilipChalupa deleted the patch-1 branch June 12, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants