Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data to input-week #2230

Merged
merged 3 commits into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@ddbeck
Copy link
Collaborator

left a comment

Looks good, @maboa. Needs a description and an adjustment to the Firefox notes and data, but it's close. Thank you!

},
"firefox": {
"version_added": false,
"notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a> and <a href='https://wiki.mozilla.org/TPE_DOM/Date_time_input_types'>TPE DOM/Date time input types</a>."

This comment has been minimized.

Copy link
@ddbeck

ddbeck Jun 22, 2018

Collaborator

This is false for both desktop and Android Firefoxes and @wbamberg's comment on #2200 applies to both as well

"input": {
"input-week": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/html/Element/input/week",

This comment has been minimized.

Copy link
@ddbeck

ddbeck Jun 22, 2018

Collaborator

Needs "description": "<code>type=\"week\"</code>"

@maboa

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2018

This should be sorted now! Thanks :)

},
"firefox": {
"version_added": false,
"notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a>."

This comment has been minimized.

Copy link
@ddbeck

ddbeck Jun 25, 2018

Collaborator

One last nit, sorry. Can we change this note to only "See <a href='https://bugzil.la/888320'>bug 888320</a>." Thank you, @maboa!

Tweaked the note

@Elchi3

Elchi3 approved these changes Jun 27, 2018

Copy link
Member

left a comment

Thanks Mark and Daniel! 👍

@Elchi3 Elchi3 merged commit 30b4ddc into mdn:master Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

gsouquet added a commit to gsouquet/browser-compat-data that referenced this pull request Jun 29, 2018

Merge branch 'master' into positionoptions
* master: (175 commits)
  Add Server-Timing header (mdn#2148)
  40th alpha version
  Add compat data for input-password (mdn#2235)
  Add addTransceiver() method for RTCPeerConnection. (mdn#2311)
  Update Payments API for Chrome. (mdn#2378)
  Add compat data for MutationObserver (mdn#2094)
  Fix compat data for "let" in Chrome (mdn#1632)
  Safari has more formdata support now (mdn#2376)
  Add compat data for Window sub features from A to F (mdn#2109)
  Add guidelines around worker support and constructors for API subfeatures (mdn#2373)
  Update place-content.json (mdn#2240)
  Add compat data for HTMLDetailsElement (mdn#2315)
  Add compat data for input-month (mdn#2204)
  Add compat data to input-week (mdn#2230)
  Add compat data for input-radio (mdn#2208)
  Add compat data for input-tel (mdn#2226)
  Add compat data for input-image (mdn#2207)
  Add compat data for input-number (mdn#2206)
  Add compat data for input-hidden (mdn#2203)
  Add compat data for input-file (mdn#2202)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.