Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating compatibility for onpopstate event #2697

Merged
merged 5 commits into from Sep 3, 2018

Conversation

Projects
None yet
2 participants
@a1626
Copy link
Contributor

commented Aug 29, 2018

source CanIUse

a1626 added some commits Aug 16, 2018

@Elchi3
Copy link
Member

left a comment

Thanks for you PR and welcome to mdn-browser-compat-data, @a1626! 🎉

Unfortunately, caniuse is a little misleading sometimes. It doesn't show you the versions when supported was added by default. You have to click the button "Showing all" to see all versions. Support for this was actually added way earlier, see my inline comments.

@@ -496,37 +496,37 @@
"version_added": null
},
"chrome": {
"version_added": null
"version_added": "49"

This comment has been minimized.

Copy link
@Elchi3
},
"edge_mobile": {
"version_added": null
},
"firefox": {
"version_added": null
"version_added": "61"

This comment has been minimized.

Copy link
@Elchi3
},
"firefox_android": {
"version_added": null
"version_added": "60"

This comment has been minimized.

Copy link
@Elchi3

This comment has been minimized.

Copy link
@Elchi3

Elchi3 Aug 30, 2018

Member

This is still 60. It should be 4 to match the desktop version.

},
"edge": {
"version_added": null
"version_added": "17"

This comment has been minimized.

Copy link
@Elchi3
},
"chrome_android": {
"version_added": null
"version_added": "67"

This comment has been minimized.

Copy link
@Elchi3

This comment has been minimized.

Copy link
@a1626

a1626 Aug 30, 2018

Author Contributor

I couldn't find this one in caniuse so i haven't changed it.

This comment has been minimized.

Copy link
@Elchi3

Elchi3 Aug 30, 2018

Member

18 is the first chrome_android version. See our browser release data: https://github.com/mdn/browser-compat-data/blob/master/browsers/chrome_android.json

},
"ie": {
"version_added": null
"version_added": "11"

This comment has been minimized.

Copy link
@Elchi3
},
"safari": {
"version_added": null
"version_added": "11.1"

This comment has been minimized.

Copy link
@Elchi3
},
"safari_ios": {
"version_added": null
"version_added": "10.3"

This comment has been minimized.

Copy link
@Elchi3

Elchi3 Aug 30, 2018

Member

"5.1"

@a1626

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2018

@Elchi3 sorry my bad. I did these changes few weeks back and forgot to send PR at that time, and i thought that i took data only after using the show all button, but it seems like that's not the case.

a1626 added some commits Aug 30, 2018

@a1626

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2018

@Elchi3 i've updated versions for chrome and firefox android but i still have a doubt. Can you share with me how did you discovered that they were the first versions that supported popstate event?

@Elchi3

This comment has been minimized.

Copy link
Member

commented Sep 3, 2018

@a1626 Thank you! These are the first versions of the browsers that have been released. See https://github.com/mdn/browser-compat-data/tree/master/browsers for release data.

@Elchi3

Elchi3 approved these changes Sep 3, 2018

@Elchi3 Elchi3 merged commit 117b4d5 into mdn:master Sep 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@a1626

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2018

@Elchi3 then that doesn't mean that the api was supported in these versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.