New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS compat data for many non-standard CSS properties/selectors #2874

Merged
merged 10 commits into from Oct 2, 2018

Conversation

Projects
None yet
4 participants
@vinyldarkscratch
Contributor

vinyldarkscratch commented Sep 27, 2018

Tackles some more of the entries on #2684. Properties and selectors involved include:

  • -webkit-border-before
  • -webkit-box-reflect
  • -webkit-mask-composite
  • :-webkit-autofill
  • ::-webkit-file-upload-button
  • ::-webkit-inner-spin-button
  • ::-webkit-outer-spin-button
  • ::-moz-color-swatch

Please note: all of the data origins from the existing MDN pages that utilize them, with no validation of the original data's accuracy.

"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/-webkit-border-before",
"support": {
"webview_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

This should be true.

"version_added": true
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

true

"version_added": "4"
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

true

"version_added": "1"
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

true

"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/:-webkit-autofill",
"support": {
"webview_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

true

"version_added": true
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

true

"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/::-webkit-inner-spin-button",
"support": {
"webview_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

true

"version_added": true
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

true

"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/::-webkit-outer-spin-button",
"support": {
"webview_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

true

"version_added": false
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Sep 27, 2018

Contributor

true

"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/-webkit-border-before",
"support": {
"webview_android": {

This comment has been minimized.

@connorshea

connorshea Sep 28, 2018

Contributor

Ideally webview_android should go at the bottom because the support array should be sorted alphabetically. We don’t lint for this right now because of how many things it’d break, unfortunately.

@Elchi3

Thanks for your PR, and thanks everyone for the reviews!
Some exports are wrong (properties -> selectors), and we require new lines at the end of files. Please set your editor to conform to the .editorconfig file of this repo.

@@ -0,0 +1,58 @@
{
"css": {
"properties": {

This comment has been minimized.

@Elchi3

Elchi3 Oct 2, 2018

Member

This is a selector

@@ -0,0 +1,58 @@
{
"css": {
"properties": {

This comment has been minimized.

@Elchi3

Elchi3 Oct 2, 2018

Member

This is also a selector

@@ -0,0 +1,58 @@
{
"css": {
"properties": {

This comment has been minimized.

@Elchi3

Elchi3 Oct 2, 2018

Member

selectors

}
}
}
}

This comment has been minimized.

@Elchi3

Elchi3 Oct 2, 2018

Member

Add a new line please

}
}
}
}

This comment has been minimized.

@Elchi3

Elchi3 Oct 2, 2018

Member

Add a new line please

}
}
}
}

This comment has been minimized.

@Elchi3

Elchi3 Oct 2, 2018

Member

Add a new line please

}
}
}
}

This comment has been minimized.

@Elchi3

Elchi3 Oct 2, 2018

Member

Add a new line please

}
}
}
}

This comment has been minimized.

@Elchi3

Elchi3 Oct 2, 2018

Member

Add a new line please

@vinyldarkscratch

This comment has been minimized.

Contributor

vinyldarkscratch commented Oct 2, 2018

Thanks for review, @Elchi3! I definitely plan on replacing my editor soon due to the whole newline issue, haha -- everything should now be fixed. 😉

@Elchi3

Elchi3 approved these changes Oct 2, 2018

Thanks for your work! 👍

@Elchi3 Elchi3 merged commit 17bef76 into mdn:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vinyldarkscratch vinyldarkscratch deleted the vinyldarkscratch:css-compat-data-2 branch Oct 2, 2018

@connorshea

This comment has been minimized.

Contributor

connorshea commented Oct 2, 2018

@vinyldarkscratch I'd recommend VS Code if you're open to suggestions :P

@vinyldarkscratch

This comment has been minimized.

Contributor

vinyldarkscratch commented Oct 2, 2018

@vinyldarkscratch I'd recommend VS Code if you're open to suggestions :P

I've tried VS Code but it runs super slow on my computer (and I have a 2017 MacBook Pro) -- I've been using something called Power JSON Editor (mostly for the graphical interface) and Sublime Text for raw code, though if they've improved on optimization I'll probably give VS Code another try!

@connorshea

This comment has been minimized.

Contributor

connorshea commented Oct 2, 2018

Odd, I have a late 2013 MacBook Pro and it runs pretty well 🤔 Not as well as Sublime did, but ultimately the superior feature set was more important for me. Whatever works for you! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment