New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge 18 changes #2907

Merged
merged 12 commits into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@merih
Contributor

merih commented Oct 3, 2018

EdgeHTML is updated to version 18 with the Windows 10 October 2018 Update: https://aka.ms/devguide_edgehtml_18

@@ -30,11 +30,13 @@
},
"17": {
"release_date": "2018-04-30",
"release_notes": "https://docs.microsoft.com/en-us/microsoft-edge/dev-guide",
"release_notes": "https://docs.microsoft.com/en-us/microsoft-edge/dev-guide/whats-new/edgehtml-17",
"status": "current"

This comment has been minimized.

@connorshea

connorshea Oct 3, 2018

Contributor

this should be retired now I think?

"status": "current"
},
"18": {
"status": "nightly"
"release_date": "2018-10-01",

This comment has been minimized.

@connorshea
@connorshea

This comment has been minimized.

Contributor

connorshea commented Oct 3, 2018

Also, it's maybe worth noting that with Edge 17, Microsoft devs contributed the updated info to the BCD themselves, I'm not sure if they'll do that again or if that'll override this PR? @Elchi3

Retire Edge 17 and update Edge 18 release date
- Revert toggleAttribute compat data for Edge Mobile
@merih

This comment has been minimized.

Contributor

merih commented Oct 3, 2018

I wasn't aware that Microsoft devs are updating BCD regularly for new Edge releases. Feel free to close this PR if they are going to provide a better compat data.

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Oct 4, 2018

Also, it's maybe worth noting that with Edge 17, Microsoft devs contributed the updated info to the BCD themselves, I'm not sure if they'll do that again or if that'll override this PR? @Elchi3

I don't know. In any case, I don't think it would override this PR. This looks good to me, maybe it is not exhaustive, but BCD isn't exhaustive overall at this point :)

@Elchi3

Elchi3 approved these changes Oct 4, 2018

Thanks for your PR and welcome to mdn-browser-compat-data! 👍 🎉

@Elchi3 Elchi3 merged commit 06bdbe3 into mdn:master Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@merih merih deleted the merih:edge-18-changes branch Oct 4, 2018

@merih

This comment has been minimized.

Contributor

merih commented Oct 4, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment