Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin Header: Firefox sent it for POST requests since v59 #2943

Merged
merged 2 commits into from Oct 30, 2018

Conversation

chtitux
Copy link
Contributor

@chtitux chtitux commented Oct 9, 2018

No description provided.

@Elchi3 Elchi3 added the data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label Oct 10, 2018
@Elchi3
Copy link
Member

Elchi3 commented Oct 10, 2018

@chrisdavidmills can you review this, given you handled the ddn a while ago? https://bugzilla.mozilla.org/show_bug.cgi?id=446344#c113

Copy link
Collaborator

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right. When I went through trying to document this, I eventually found out that the Origin header is sent with non-CORS requests since Fx59, unless they are GET or HEAD (see https://bugzilla.mozilla.org/show_bug.cgi?id=446344#c117).

You also need to add to the BCD to mention this is currently behind a pref (see https://bugzilla.mozilla.org/show_bug.cgi?id=1424076).

Thanks for working on this!

@@ -20,7 +20,7 @@
},
"firefox": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

             "firefox": [
               {
                 "version_added": 59
               },
               {
                 "version_added": true,
                 "partial_implementation": true,
                 "notes": "Not sent with <code>POST</code> requests until Firefox 58, see <a href='https://bugzil.la/446344'>bug 446344</a>."
               }
             ]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdavidmills would this work for you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion misses the required pref and should also be revised as "Not sent with same-origin POST".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the 59 information, sdd the pref, and also add a note long the lines of "sent with non-CORS requests since Fx59, unless they are GET or HEAD"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this. Does it look good to you now, @chrisdavidmills?

Copy link
Collaborator

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks better, yes. It's not great, as this is an annoying complex bit of information to represent. But I don't think we'll get it much better.

@chrisdavidmills chrisdavidmills merged commit 47f1979 into mdn:master Oct 30, 2018
@chrisdavidmills
Copy link
Collaborator

Thanks for your work all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants