New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed support info for FormData methods in Safari #2988

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@nirazul
Contributor

nirazul commented Oct 15, 2018

As I needed the data in a project, I've tested the support of the FormData methods in several Safari versions via Browserstack. It's based on inspecting the FormData prototype in the developer console.
Unfortunately, I haven't found any hard evidence backing my claims.

@Elchi3 Elchi3 requested a review from chrisdavidmills Oct 15, 2018

@chrisdavidmills

Hi there! This mostly looks fine, but I think the 3-argument version of append() (AppendWithFileName) is supported in Safari 10, not 9.

I tested all this by writing myself a simple test case, putting it at https://chrisdavidmills.github.io/formdata-test/, and testing it on different versions of Safari via SauceLabs.

The newer methods all appear in the object from Safari 11 onwards, so you are right on those.

But the try catch block only passes from Safari 10 onwards. It fails and explodes and makes the demo show no results from 9 downwards, which was not quite the result I was expecting, but I've not got time to fix it at the moment, and I think it still shows a good indication.

@nirazul

This comment has been minimized.

Contributor

nirazul commented Oct 16, 2018

@chrisdavidmills Thanks for checking things!

I've looked into your example on Safari 9. There has been an error in the for loop that prevented the test results from being shown. The let keyword is supported in Safari 10 and upwards.

Here's a reduced codepen example where I've fixed it. If you look at it in a Safari 9 browser you'll see that the syntax is supported:
https://codepen.io/nirazul/full/QZaMNa/

Another hint is shown when you inspect a FormData object:

dashboard

@chrisdavidmills

Ah, Brilliant, thanks for the debugging help! Yup, I now see that it does work in SAf 9; PR approved and ready to merge.

@Elchi3

Elchi3 approved these changes Oct 16, 2018

Thanks for the PR @nirazul and welcome to mdn-browser-compat-data! 🎉

@chrisdavidmills thanks for the review! Feel free to merge PRs yourself when you approve them :)

@Elchi3 Elchi3 merged commit bf15ed2 into mdn:master Oct 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment