New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selection API compat data for Chrome and Opera #3032

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@hexrcs
Contributor

hexrcs commented Oct 28, 2018

Selection API should be fully supported at least since Chrome 58/Opera 45.

@hexrcs hexrcs force-pushed the hexrcs:master branch from 0f6ef4a to 18ce657 Oct 28, 2018

@@ -54,10 +54,10 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Selection/addRange",
"support": {
"chrome": {
"version_added": null
"version_added": true

This comment has been minimized.

@jpmedley

jpmedley Oct 29, 2018

Contributor

Should be 1. Leave the other flavors of Chrome as true.

@@ -102,10 +102,10 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Selection/anchorNode",
"support": {
"chrome": {
"version_added": null
"version_added": true

This comment has been minimized.

@jpmedley

jpmedley Oct 29, 2018

Contributor

1

@@ -150,10 +150,10 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Selection/anchorOffset",
"support": {
"chrome": {
"version_added": null
"version_added": true

This comment has been minimized.

@jpmedley

jpmedley Oct 29, 2018

Contributor

1

Show resolved Hide resolved api/Selection.json Outdated
@@ -1258,10 +1258,10 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Selection/toString",
"support": {
"chrome": {
"version_added": null
"version_added": true

This comment has been minimized.

@jpmedley

jpmedley Oct 29, 2018

Contributor

1

This comment has been minimized.

@hexrcs

hexrcs Oct 29, 2018

Contributor

Done.

@Elchi3

Elchi3 approved these changes Oct 29, 2018

Thanks to both of you! 👍

@Elchi3 Elchi3 merged commit 98d15ee into mdn:master Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment