New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display-mode is not supported by Samsung Browser #3153

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
3 participants
@Sumurai8
Copy link
Contributor

Sumurai8 commented Nov 29, 2018

display-mode does not work for Samsung Browser. A bug about this can be found at SamsungInternet/support#45

Manual testing shows that CSS selectors (as in @media all and (display-mode: standalone) {) for standalone and fullscreen do not work. The javascript query window.matchMedia('(display-mode: standalone)').matches for standalone and fullscreen return false. Only the query window.matchMedia('(display-mode: browser)').matches returns true for both standalone and fullscreen.

display-mode is not supported by Samsung Browser
`display-mode` does not work for Samsung Browser. A bug about this can be found at SamsungInternet/support#45

Manual testing shows that CSS selectors (as in `@media all and (display-mode: standalone) {`) for standalone and fullscreen do not work. The javascript query `window.matchMedia('(display-mode: standalone)').matches` for standalone and fullscreen return false. Only the query `window.matchMedia('(display-mode: browser)').matches` returns true for both standalone and fullscreen.
@ddbeck

ddbeck approved these changes Dec 5, 2018

Copy link
Collaborator

ddbeck left a comment

Hi @Sumurai8 and welcome to BCD! Thanks for looking into this and submitting a fix!

@ddbeck ddbeck merged commit 013e52f into mdn:master Dec 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment