New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookbehind has no firefox support #3189

Merged
merged 3 commits into from Dec 11, 2018

Conversation

Projects
None yet
4 participants

StefanSchoof added some commits Dec 7, 2018

},
"ie": {
"version_added": null
},
"nodejs": {
"version_added": null
"version_added": 9

This comment has been minimized.

@freaktechnik

freaktechnik Dec 7, 2018

Contributor

You'll want this to be a string of the exact node version it was added, so something like "9.10.12" (which is probably not the actual version it was added, but that's what's expected).

This comment has been minimized.

@StefanSchoof

StefanSchoof Dec 8, 2018

Author Contributor

I don't know the exact version, so I removed it

Remove node lookbehind
I do not know the exact version. So remove.

@Elchi3 Elchi3 added the data:js 📟 label Dec 9, 2018

@ddbeck

ddbeck approved these changes Dec 11, 2018

Copy link
Collaborator

ddbeck left a comment

Welcome to BCD @StefanSchoof and thank you for this PR. Looks good! 🎉

@ddbeck ddbeck merged commit 1c1f10d into mdn:master Dec 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment