New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for await...of #3194

Merged
merged 4 commits into from Dec 12, 2018

Conversation

Projects
None yet
4 participants

YuichiNukiyama added some commits Dec 9, 2018

@Elchi3 Elchi3 added the data:js 📟 label Dec 9, 2018

"version_added": "63"
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Dec 10, 2018

Contributor

This should match Chrome, as should webview_android.

Please wait to change this. I want to confirm the version number.

This comment has been minimized.

@jpmedley

jpmedley Dec 10, 2018

Contributor

Confirmed. Please change.

"version_added": "63"
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Dec 10, 2018

Contributor

Confirmed. Please change.

@YuichiNukiyama

This comment has been minimized.

Copy link
Contributor Author

YuichiNukiyama commented Dec 11, 2018

Thanks for your review
I add Opera's support, too.
https://www.chromestatus.com/feature/5727385018171392

@ddbeck
Copy link
Collaborator

ddbeck left a comment

Hi @YuichiNukiyama and welcome to BCD! Thanks for this PR. One adjustment to make and then we'll be ready to merge. Thank you!

},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ddbeck

ddbeck Dec 11, 2018

Collaborator

This looks to be on the standards track.

Suggested change Beta
"standard_track": false,
"standard_track": true,

@ddbeck ddbeck dismissed their stale review Dec 11, 2018

wrong status

@YuichiNukiyama

This comment has been minimized.

Copy link
Contributor Author

YuichiNukiyama commented Dec 12, 2018

😄

@ddbeck

ddbeck approved these changes Dec 12, 2018

@ddbeck

This comment has been minimized.

Copy link
Collaborator

ddbeck commented Dec 12, 2018

Thank you, @YuichiNukiyama! 🎉

@ddbeck ddbeck merged commit 9c2d008 into mdn:master Dec 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@YuichiNukiyama YuichiNukiyama deleted the YuichiNukiyama:for_await_of branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment