Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd compat for BigInt #3224
Conversation
jpmedley
suggested changes
Dec 18, 2018
Thank you for your help on this. |
BigInt.json Outdated
BigInt.json Outdated
BigInt.json Outdated
BigInt.json Outdated
BigInt.json Outdated
ddbeck
added
the
data:js 📟
label
Dec 18, 2018
This comment has been minimized.
This comment has been minimized.
I added a commit to fix the errors. |
jpmedley
approved these changes
Dec 18, 2018
chicoxyzzy
reviewed
Dec 18, 2018
BigInt.json Outdated
This comment has been minimized.
This comment has been minimized.
I added a commit with the Node.js compatibility, and put it in the correct folder |
chicoxyzzy
approved these changes
Dec 19, 2018
This comment has been minimized.
This comment has been minimized.
I un-localized the URL. |
ddbeck
reviewed
Dec 20, 2018
javascript/builtins/BigInt.json Outdated
javascript/builtins/BigInt.json Outdated
javascript/builtins/BigInt.json Outdated
This comment has been minimized.
This comment has been minimized.
I added a commit with those style changes. |
This comment has been minimized.
This comment has been minimized.
Travis CI says: "
" |
This comment has been minimized.
This comment has been minimized.
It appears that your line endings aren't just new lines (i.e., your line endings are Windows rather than Unix style). I've opened PR #3231 to highlight this better. In the mean time, there's probably an option in your editor to convert line endings, which should fix the problem. |
This comment has been minimized.
This comment has been minimized.
I changed the line endings (I said Unicode but meant Unix). Travis CI said the same thing. Maybe there is a bug with Travis CI, because I changed the line endings |
ddbeck
added some commits
Dec 24, 2018
ddbeck
dismissed
their
stale review
Dec 24, 2018
Fixed!
This comment has been minimized.
This comment has been minimized.
ddbeck
merged commit c7e3a3b
into
mdn:master
Dec 24, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
Thank you for merging the commits! I'm also on MDN under the username VFDan. |
mdn
deleted a comment from
QuyenNguyenCDA
Jan 16, 2019
This comment has been minimized.
This comment has been minimized.
I put the compatibility table in the MDN BigInt page. |
VFDan commentedDec 17, 2018
•
edited
The BigInt compatibility table is needed:
Sorry, the file should be in the javascript/builtins/ folder.