New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Referrer-Policy same-origin / strict-origin version for Chrome #366

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Projects
None yet
3 participants
@TimWolla
Contributor

TimWolla commented Sep 8, 2017

This was implemented as of Google Chrome 61: https://bugs.chromium.org/p/chromium/issues/detail?id=627968#c15.

Most likely it is implemented in mobile Chrome 61 as well, but I did not check. Feel free to adapt the pull request.

@Elchi3

This comment has been minimized.

Show comment
Hide comment
@Elchi3

Elchi3 Sep 10, 2017

Member

Thanks for contributing to MDN! This change looks good to me.
I'm wondering what's up with strict-origin-when-cross-origin. It's not implemented as part of that issue? We should probably remove the note from it then. Maybe @jpmedley knows more and/or can double check this.

Member

Elchi3 commented Sep 10, 2017

Thanks for contributing to MDN! This change looks good to me.
I'm wondering what's up with strict-origin-when-cross-origin. It's not implemented as part of that issue? We should probably remove the note from it then. Maybe @jpmedley knows more and/or can double check this.

@TimWolla

This comment has been minimized.

Show comment
Hide comment
@TimWolla

TimWolla Sep 10, 2017

Contributor

I'm wondering what's up with strict-origin-when-cross-origin. It's not implemented as part of that issue?

I'm not quite sure, I think it may be implemented also, but I did not check and mainly wanted to bring the changes to your attention. The issue say this:

and repurposes existing logic that was previously only available behind a flag for 'strict-origin-when-cross-origin'.

Contributor

TimWolla commented Sep 10, 2017

I'm wondering what's up with strict-origin-when-cross-origin. It's not implemented as part of that issue?

I'm not quite sure, I think it may be implemented also, but I did not check and mainly wanted to bring the changes to your attention. The issue say this:

and repurposes existing logic that was previously only available behind a flag for 'strict-origin-when-cross-origin'.

@Elchi3

https://www.chromestatus.com/feature/5634117806850048 mentions it as well.
We could be adding these versions, given the chromestatus info:
Chrome for desktop release 61
Chrome for Android release 61
Android WebView release 61
Opera release 48
Opera for Android release 48

(and please use "61" rather than "61.0.)

@TimWolla

This comment has been minimized.

Show comment
Hide comment
@TimWolla

TimWolla Sep 15, 2017

Contributor

@Elchi3

We could be adding these versions, given the chromestatus info:

Okay. Done.

(and please use "61" rather than "61.0.)

I used the version in the __compat key as an example. I changed it to 61 from 61.0, but did not change the versions in __compat. If I should do so please comment.

Contributor

TimWolla commented Sep 15, 2017

@Elchi3

We could be adding these versions, given the chromestatus info:

Okay. Done.

(and please use "61" rather than "61.0.)

I used the version in the __compat key as an example. I changed it to 61 from 61.0, but did not change the versions in __compat. If I should do so please comment.

@Elchi3

Elchi3 approved these changes Sep 15, 2017

I used the version in the __compat key as an example. I changed it to 61 from 61.0, but did not change the versions in __compat. If I should do so please comment.

Sorry about the confusion here! We are going to add some validation about this soon. There is no need to change the existing versions in __compat. Thanks for your updates, this is good to go!

@Elchi3 Elchi3 merged commit d62aa42 into mdn:master Sep 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@TimWolla TimWolla deleted the TimWolla:patch-1 branch Sep 15, 2017

@jpmedley

This comment has been minimized.

Show comment
Hide comment
@jpmedley

jpmedley Sep 15, 2017

Contributor

Official Google response here. There should never be a decimal and a 0 for Chrome versions.

Contributor

jpmedley commented Sep 15, 2017

Official Google response here. There should never be a decimal and a 0 for Chrome versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment