New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify onCreatedNavigationTarget support for Chrome (WebExtensions) #370

Merged
merged 1 commit into from Sep 9, 2017

Conversation

Projects
None yet
3 participants
@Baptistou
Contributor

Baptistou commented Sep 9, 2017

The value windowId is not supported by Chrome in the API chrome.webNavigation.onCreatedNavigationTarget.
I encountered this issue when developping my addon for Firefox and Chrome while it doesn't appear in MDN.
MDN: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webNavigation/onCreatedNavigationTarget#details
Chrome: https://developer.chrome.com/extensions/webNavigation#event-onCreatedNavigationTarget

Modify onCreatedNavigationTarget support for Chrome
The value windowId is not supported by Chrome in the API chrome.webNavigation.onCreatedNavigationTarget.
I encountered this issue when developping my addon for Firefox and Chrome while it doesn't appear in MDN.
MDN: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webNavigation/onCreatedNavigationTarget#details
Chrome: https://developer.chrome.com/extensions/webNavigation#event-onCreatedNavigationTarget

@Baptistou Baptistou changed the title from Modify onCreatedNavigationTarget support for Chrome to Modify onCreatedNavigationTarget support for Chrome (WebExtensions) Sep 9, 2017

@wbamberg

Thanks for your contribution, @Baptistou !

@wbamberg wbamberg merged commit 432116e into mdn:master Sep 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Baptistou Baptistou deleted the Baptistou:patch-1 branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment