feat(TypeScript): Update types #3739
Conversation
| if (prop === 'support') { | ||
| checkVersions(data[prop]); | ||
| if (prop === '__compat' && data[prop].support) { | ||
| checkVersions(data[prop].support); |
There was a problem hiding this comment.
This operation was previously type unsafe, and could lead to a potential crash if there was a feature in BCD named support.
Elchi3
added
infra 🏗️
ExE-Boss
force-pushed
the
typescript/add-matches-block
branch
2 times, most recently
from
1a962cf
to
38364fa
Compare
|
review?(@vinyldarkscratch): This no longer depends on #3737, so it can be merged as‑is. P.S.: Can you please remove the not ready label? |
queengooborg
removed
the
not ready ⛔
| @@ -1,8 +1,6 @@ | |||
| /* Any copyright is dedicated to the Public Domain. | |||
| * http://creativecommons.org/publicdomain/zero/1.0/ */ | |||
|
|
|||
| export as namespace bcd; | |||
There was a problem hiding this comment.
I previously misunderstood what export as namespace meant.
I now know that this means export as a UMD global, which doesn’t exist.
ExE-Boss
force-pushed
the
typescript/add-matches-block
branch
from
ac60de7
to
726016c
Compare
|
I'm not entirely certain what problem this fixes (and to be honest, I'm not experienced with TypeScript). From the basic tests to make sure the data still works as expected, I've found no issues. Is there a specific issue this resolves, or is it more of a maintenance update? |
|
This is more of a maintenance update so that the |
review?(@crutchcorn, @Elchi3, @vinyldarkscratch): This no longer depends on #3737 and can be merged as‑is.