Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update support of optional try/catch bindings #4403

Merged
merged 1 commit into from Jul 1, 2019
Merged

Update support of optional try/catch bindings #4403

merged 1 commit into from Jul 1, 2019

Conversation

stefanjudis
Copy link
Contributor

@stefanjudis stefanjudis commented Jun 30, 2019 •
edited

I noticed that optional catch bindings are supported in recent Edge/Safari and added these. :)

I took the support information for Safari from kangax compat table.

For Edge it's supported since the move to Chromium which makes 76. :) You can verify this by opening the new Edge and try it in the console. :)

Screenshot 2019-06-30 at 13 49 36

Thanks for the good work. :)

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@stefanjudis
Copy link
Contributor Author

Hmm... not sure about failing CI. Is BCD not tracking the new Edge yet?

queengooborg
queengooborg requested changes Jun 30, 2019
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thanks for your PR, and welcome to BCD! That is correct, BCD is not yet tracking the Chromium-based Microsoft Edge releases, since they are still within beta stages. Most likely, once it's out, we'll mirror any Chromium data over to Edge values with false or null in one swoop.

For now, let's leave Edge as is, and keep the Safari support info?

@queengooborg queengooborg added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jun 30, 2019
@queengooborg queengooborg mentioned this pull request Jul 1, 2019
Closed
@stefanjudis
Update support of optional try/catch bindings
a07ae9a 
I noticed that optional catch bindings are supported in recent Edge/Safari.

I took the support information for Safari from [kangax compat table](https://kangax.github.io/compat-table/es2016plus/#test-optional_catch_binding).

For Edge it's supported since the move to Chromium which makes `76`. :)

Thanks for the good work. :)
@stefanjudis
Copy link
Contributor Author

@vinyldarkscratch Works for me. Done. :)

queengooborg
queengooborg approved these changes Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks for the quick updates! And once again, welcome to BCD. 😉

(P.S. we squash merge all pull requests here, so no need to force push!)

@queengooborg queengooborg merged commit bd5400d into mdn:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanjudis @queengooborg