Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention a couple of WebExtension API polyfills #4423

Merged
merged 3 commits into from Jul 2, 2019

Conversation

Projects
None yet
3 participants
@bfred-it
Copy link
Contributor

commented Jul 1, 2019

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • the Permissions API event is missing from firefox
  • contentScripts.register is missing from Chrome

So I added these two polyfills to the table

  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)

bugzilla for the missing events

  • Data: if you tested something, describe how you tested with details like browser and version

Both were tested in Refined GitHub to register existing content scripts on new hosts.

  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

This follows the existing mentions of polyfills: https://github.com/mdn/browser-compat-data/search?q=polyfill&unscoped_q=polyfill

bfred-it added some commits Jul 1, 2019

@bfred-it bfred-it marked this pull request as ready for review Jul 1, 2019

@bfred-it bfred-it requested a review from irenesmith as a code owner Jul 1, 2019

@vinyldarkscratch vinyldarkscratch requested a review from ddbeck Jul 1, 2019

@irenesmith
Copy link
Collaborator

left a comment

LGTM

@irenesmith irenesmith merged commit b414f83 into mdn:master Jul 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bfred-it bfred-it deleted the bfred-it:patch-1 branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.