Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 69: Add deviceId/facingMode/groupId to track settings #4561

Merged
merged 2 commits into from Aug 22, 2019

Conversation

a2sheppy
Copy link
Contributor

@a2sheppy a2sheppy commented Aug 2, 2019

Starting in Firefox 69, these three members of the MediaTrackSettings
object are set on return from getSettings().

Sources:

Starting in Firefox 69, these three members of the MediaTrackSettings
object are set on return from `getSettings()`.

Sources:
* https://bugzilla.mozilla.org/show_bug.cgi?id=1398180
* https://bugzilla.mozilla.org/show_bug.cgi?id=1537986
@ddbeck ddbeck added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 5, 2019
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! I think that we can reword the note just a little bit -- I'm not strong on the wording, though. 😛

api/MediaTrackConstraints.json Outdated Show resolved Hide resolved
@Elchi3
Copy link
Member

Elchi3 commented Aug 21, 2019

@a2sheppy do you plan to come back to this PR? I think the suggestion makes sense. Happy to commit and merge that if you have no time.

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the changes to the notes -- I think we're ready to merge this!

@queengooborg queengooborg merged commit e6a0f7d into mdn:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants