Add npm as a deployment provider to travis #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
the
infra 🏗️
jwhitlock
suggested changes
Oct 27, 2017
.travis.yml
Outdated
| secure: tPV4Rve++cmJeYOEhB0/bYaUVIxx9fyKm3Nn4mEBoTuqUojxCzjYaRNqhCREUigQayKDd6Efa6tzHbTygyU41WUNRLtRYENqv060nj8Bdzx7bjgm8dRqdctrvgisfqBfuQa+5MbliZblhD6M7ZyoURqK2stY64JGhvonKG1w0zl2sVyhDNSzoJwx6dx57upkVvXFqk4PQtmtLxRc27YlEiPa7yUCkXYUVCrQVQst7iJfR3pOvvfsR3lhyCJqVrV7cFgTy1VmpxHK/PjbVMJx4JahLbDHbS1I+jRWwx8/aPKMuQfoDn+34Y6uqVe+NaAwoy7bppsKOx/hpAY9HNfLBjIk8oe2n1JXmQg9J8bQ4sIijn1uflcly+LD2FYJSqtkHSsTSTiGHSH6+0O79tYcFRp3E62Xq+ED4Bx4h44Il4W9Z9ggrU4Lcp5BzNGgwf76U6V/Gx/vgd4BmiyDV/7+1MrHJxM67P/5rNAD+fdYQ6Hh5d7765ljBT4ttokoyhgKhEA5ShjPVt+ubotbgJ7ixY72O926qEAvQ7n74dEd4vnGXp2cO/h2dEPAstENY1xeuMyT4fz2CZ/zCr6xEZ9vkevPSFXoHdk2BzrFKLhelBZw9VqmD5RSwhR4/6dB4VxMWB79QACdHslMCWkFVgiFWTuAa4Prmd7J6E5B03dtHd4= | ||
| on: | ||
| tags: true | ||
| branch: master |
There was a problem hiding this comment.
I believe branch: master says to release with each merge to master. Please remove this line and just leave the tags one.
There was a problem hiding this comment.
Thanks, I think I misunderstood the docs.
.travis.yml
Outdated
| provider: npm | ||
| email: mdn-npm@mozilla.com | ||
| api_key: | ||
| secure: tPV4Rve++cmJeYOEhB0/bYaUVIxx9fyKm3Nn4mEBoTuqUojxCzjYaRNqhCREUigQayKDd6Efa6tzHbTygyU41WUNRLtRYENqv060nj8Bdzx7bjgm8dRqdctrvgisfqBfuQa+5MbliZblhD6M7ZyoURqK2stY64JGhvonKG1w0zl2sVyhDNSzoJwx6dx57upkVvXFqk4PQtmtLxRc27YlEiPa7yUCkXYUVCrQVQst7iJfR3pOvvfsR3lhyCJqVrV7cFgTy1VmpxHK/PjbVMJx4JahLbDHbS1I+jRWwx8/aPKMuQfoDn+34Y6uqVe+NaAwoy7bppsKOx/hpAY9HNfLBjIk8oe2n1JXmQg9J8bQ4sIijn1uflcly+LD2FYJSqtkHSsTSTiGHSH6+0O79tYcFRp3E62Xq+ED4Bx4h44Il4W9Z9ggrU4Lcp5BzNGgwf76U6V/Gx/vgd4BmiyDV/7+1MrHJxM67P/5rNAD+fdYQ6Hh5d7765ljBT4ttokoyhgKhEA5ShjPVt+ubotbgJ7ixY72O926qEAvQ7n74dEd4vnGXp2cO/h2dEPAstENY1xeuMyT4fz2CZ/zCr6xEZ9vkevPSFXoHdk2BzrFKLhelBZw9VqmD5RSwhR4/6dB4VxMWB79QACdHslMCWkFVgiFWTuAa4Prmd7J6E5B03dtHd4= |
There was a problem hiding this comment.
I was surprised this was inserted into .travis.yml - I was expecting a server-side secret, such as https://www.npmjs.com/package/travis-deploy-example. But, this is what travis setup npm spits out, so I assume it is correct.
There was a problem hiding this comment.
I've added NPM_TOKEN as an environment variable to the travis repo settings now.
Elchi3
force-pushed
the
travis-packaging
branch
from
340ea80
to
041ba90
Compare
|
Thanks for the updates! Let's try it for the Monday update 😬 |
jwhitlock
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the steps here https://docs.travis-ci.com/user/deployment/npm/
(basically, I just did
$ travis setup npm)With this, everyone with push access should be able to push a new tag, for example like this:
And then this should: