Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update <iframe sandbox=allow-downloads> for Firefox and Chrome #6668

Merged
merged 1 commit into from Sep 17, 2020

Conversation

evilpie
Copy link
Contributor

@evilpie evilpie commented Sep 10, 2020

I manually tested in Firefox 82 and Chrome 85, but used the following
references for 81 and 83 respectively.

https://bugzilla.mozilla.org/show_bug.cgi?id=1558394
https://www.chromestatus.com/feature/5706745674465280

Fixes #6667

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Sep 10, 2020
@evilpie
Copy link
Contributor Author

evilpie commented Sep 10, 2020

Btw. The lint doesn't accept Firefox for Android version 81: html.elements.iframe.sandbox-allow-downloads - version_added: "81" is NOT a valid version number for firefox_android

@jpmedley
Copy link
Collaborator

LGTM for Chrome part.

@ddbeck ddbeck changed the title Fixes #6667 <iframe sandbox=allow-downloads> Update <iframe sandbox=allow-downloads> for Firefox and Chrome Sep 15, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Sep 15, 2020

I just retitled this PR, mostly to move the issue link into the body to properly link them. I've also opened #6696 to unblock the Firefox for Android issue.

I manually tested in Firefox 82 and Chrome 85, but used the following
references for 81 and 83 respectively.

https://bugzilla.mozilla.org/show_bug.cgi?id=1558394
https://www.chromestatus.com/feature/5706745674465280
@evilpie
Copy link
Contributor Author

evilpie commented Sep 16, 2020

Rebased on top #6696 and added Firefox for Android. Please merge

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @evilpie! 🎉

@ddbeck ddbeck merged commit a3b3193 into mdn:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sandbox=allow-downloads
3 participants