Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSS] image-set() support #3456

Closed
chrisdavidmills opened this issue Mar 24, 2021 · 3 comments
Closed

[CSS] image-set() support #3456

chrisdavidmills opened this issue Mar 24, 2021 · 3 comments
Assignees
Labels
Content:CSS Cascading Style Sheets docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Mar 24, 2021

Acceptance criteria

    • The listed features are documented sufficiently on MDN
    • BCD is updated
    • Interactive example and data repos are updated if appropriate
    • The content has been reviewed as needed

Features to document

  1. image-set() as a value for content and cursor properties.
  2. image-set() function in general

Related Gecko bugs

For folks helping with Firefox-related documentation features — make sure above AC have been done, but also:

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release
@rachelandrew
Copy link
Collaborator

@chrisdavidmills This isn't actually in the spec yet for cursor (although it does say that UAs can support image) w3c/csswg-drafts#5831

So we probably don't want to add too much to the page right now. I'm wondering about BCD for cursor also? Should I add a line about support for <image>? As that is really where image-set() comes from, this is a change to allow the cursor property to support <image>, the but of implementation in 88 is adding the support for image-set to cursor.

@rachelandrew
Copy link
Collaborator

  • content I have updated the page and checked that the syntax correctly includes image-set() it already did
  • for cursor there is still a lot of discussion on this [css-ui-4] Added image-set() function to 'cursor' property w3c/csswg-drafts#6153 so I think it is probably premature to do too much in the way of documentation or BCD. I'm not sure it really needs much anyway as image-set being supported is the main thing, we only really need to document it on cursor if it behaves differently.
  • BCD is updated for image-set()
  • Release notes are done
  • Updated the three Bugzilla bugs

@rachelandrew rachelandrew moved this from To do to Needs review in Firefox 88 (April 19 2021) Mar 31, 2021
@chrisdavidmills
Copy link
Contributor Author

This one looks like it can be closed too.

@chrisdavidmills chrisdavidmills moved this from Needs review to Done in Firefox 88 (April 19 2021) Apr 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 88 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:CSS Cascading Style Sheets docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
No open projects
Development

No branches or pull requests

3 participants