Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[page type] Add page-type for CSS recipes #21165

Merged
merged 1 commit into from Sep 29, 2022

Conversation

wbamberg
Copy link
Collaborator

This PR assigns page-type: "guide" values for CSS recipe pages.

Part of #15540.

I'm on the fence about these pages.

In #15540 I suggested making them a "css-recipe" type and there are reasons for that: they're clearly a specific kind of page, and they have a distinctive structure.

On the other hand, I think having as few types as possible is a good thing, and there are only a few of these pages, and tbh they don't seem to be an integral part of the reference docs. I think that it's OK to treat these as guide pages for now, and we can always invent a dedicated type in future if it seems worth doing (like, if we put a lot more work into them in future we might want to define/enforce a structure for them).

So in this PR I'm making them guide pages.

@wbamberg wbamberg requested a review from a team as a code owner September 28, 2022 20:47
@wbamberg wbamberg requested review from dipikabh and removed request for a team September 28, 2022 20:47
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Sep 28, 2022
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@dipikabh dipikabh merged commit 326a2a7 into mdn:main Sep 29, 2022
@wbamberg wbamberg deleted the css-recipe-page-types branch October 15, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants