Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the definition of higher order function #21321

Merged
merged 5 commits into from Oct 6, 2022
Merged

docs: update the definition of higher order function #21321

merged 5 commits into from Oct 6, 2022

Conversation

Daggron
Copy link
Contributor

@Daggron Daggron commented Oct 6, 2022 •
edited

  • Update the note for higher order function to represent a complete definition of higher order functions

Description

  • Updated the side note for Higher order functions which was representing incomplete definition.

Motivation

  • Devs were confusing here that a function which returns another function can only be called a higher order function, which is incomplete, The complete definition of HOF is a function which either takes other functions as argument or return a function is called an HOF

Same Definition here -> https://eloquentjavascript.net/05_higher_order.html#h_xxCc98lOBK

Additional details

Related issues and pull requests

@Daggron
docs: update the definition of higher order function
d04da7a 
- Update the note for higher order function to represent a complete definition of higher order functions
@Daggron Daggron requested a review from a team as a code owner October 6, 2022 04:24
@Daggron Daggron requested review from hamishwillee and removed request for a team October 6, 2022 04:24
@github-actions github-actions bot added the Content:Glossary Glossary entries label Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022 •
edited

Preview URLs

(this comment was updated 2022-10-06 17:20:06.711960)

@Daggron Daggron requested review from Josh-Cena and removed request for hamishwillee October 6, 2022 17:07
@Daggron Daggron requested a review from Josh-Cena October 6, 2022 17:29
Josh-Cena
Josh-Cena approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and congratulations on landing your first PR here—welcome aboard!

@Josh-Cena Josh-Cena merged commit 1022a27 into mdn:main Oct 6, 2022
@Daggron
Copy link
Contributor Author

Daggron commented Oct 6, 2022

Thanks, and congratulations on landing your first PR here—welcome aboard!

Thankyou 🎉

@Daggron Daggron deleted the patch-1 branch January 30, 2023 17:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
Content:Glossary Glossary entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Daggron @Josh-Cena