Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrong code example for overlaysContent #23369

Merged
merged 1 commit into from Jan 4, 2023
Merged

fix: Wrong code example for overlaysContent #23369

merged 1 commit into from Jan 4, 2023

Conversation

jaandrle
Copy link
Contributor

@jaandrle jaandrle commented Jan 4, 2023

I think there is mistake in code example in navigator.virtualKeyboard for overlaysContent.

@jaandrle jaandrle requested a review from a team as a code owner January 4, 2023 10:15
@jaandrle jaandrle requested review from wbamberg and removed request for a team January 4, 2023 10:15
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jan 4, 2023
@sideshowbarker sideshowbarker merged commit 93fa3c8 into mdn:main Jan 4, 2023
5 checks passed
@sideshowbarker
Copy link
Collaborator

Jan, thanks much for catching this and fixing it, and congrats on landing your first docs change here — welcome aboard 🎉

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Preview URLs

@jaandrle jaandrle deleted the patch-1 branch January 4, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaandrle @sideshowbarker