move `beforeinput` event and `input` event from `HTMLElement` to `Element` #30288

skyclouds2001 · 2023-11-15T09:47:52Z

Description

in UI Events, the beforeinput event and input event has failed link, this is because the two events' documentation is only written under HTMLElement not under Element

and other event types (like mouse events) in the standard that target to element do documented in Element rather then HTMLElement

(also, interstingly, as I check via event handle property (like oninput), they are available on HTMLElement SVGElement or MathMLElement, and Window or Document, but not available on Element, this also happens to other UI Events, this behavior is similar to Pointer Events and Touch Events)

also add Element: auxclick and Element: contextmenu into group data of UI Events, see https://w3c.github.io/uievents/

Motivation

Additional details

Related issues and pull requests

github-actions · 2023-11-15T09:49:52Z

Preview URLs (48 pages)

Flaws (27)

Note! 37 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLSelectElement
Title: HTMLSelectElement
Flaw count: 10

macros:
- /en-US/docs/Web/API/HTMLSelectElement/length does not exist
- /en-US/docs/Web/API/HTMLSelectElement/multiple does not exist
- /en-US/docs/Web/API/HTMLSelectElement/name does not exist
- /en-US/docs/Web/API/HTMLSelectElement/required does not exist
- /en-US/docs/Web/API/HTMLSelectElement/size does not exist
- and 5 more flaws omitted

URL: /en-US/docs/Web/API/PerformanceEventTiming
Title: PerformanceEventTiming
Flaw count: 1

macros:
- /en-US/docs/Web/API/HTMLElement/pointerrawupdate_event does not exist

URL: /en-US/docs/Web/API/Element/beforeinput_event
Title: Element: beforeinput event
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.Element.beforeinput_event

URL: /en-US/docs/Web/API/Element/input_event
Title: Element: input event
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: api.Element.input_event

URL: /en-US/docs/Web/API/HTMLElement
Title: HTMLElement
Flaw count: 1

macros:
- /en-US/docs/Web/API/HTMLElement/attributeStyleMap does not exist

URL: /en-US/docs/Web/API/HTML_DOM_API
Title: The HTML DOM API
Flaw count: 5

macros:
- /en-US/docs/Web/API/HTMLDirectoryElement does not exist
- /en-US/docs/Web/API/HTMLFrameElement does not exist
- /en-US/docs/Web/API/HTMLIsIndexElement does not exist
- /en-US/docs/Web/API/External does not exist
- /en-US/docs/Web/API/ApplicationCache does not exist

URL: /en-US/docs/Web/HTML/Element/input/month
Title: <input type="month">
Flaw count: 2

macros:
- /en-US/docs/Web/API/HTMLInputElement/value does not exist
- /en-US/docs/Web/API/HTMLInputElement/value does not exist

URL: /en-US/docs/Web/HTML/Element/input/week
Title: <input type="week">
Flaw count: 1

macros:
- /en-US/docs/Web/API/HTMLInputElement/value does not exist

URL: /en-US/docs/Web/HTML/Element/input/password
Title: <input type="password">
Flaw count: 3

macros:
- /en-US/docs/Web/API/HTMLInputElement/selectionStart does not exist
- /en-US/docs/Web/API/HTMLInputElement/selectionEnd does not exist
- /en-US/docs/Web/API/HTMLInputElement/selectionDirection does not exist

URL: /en-US/docs/Web/HTML/Element/input/range
Title: <input type="range">
Flaw count: 1

macros:
- /en-US/docs/Web/API/HTMLInputElement/valueAsNumber does not exist

URL: /en-US/docs/Mozilla/Firefox/Releases/14
Title: Firefox 14 for developers
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/JavaScript_code_modules/BookmarkHTMLUtils.jsm

External URLs (1)

URL: /en-US/docs/Web/API/Document/execCommand
Title: Document: execCommand() method

https://bugzil.la/1634262 (1 time) (Note! This may be a new URL 👀)

(comment last updated: 2024-01-08 12:11:27)

bsmth · 2023-11-17T09:06:18Z

Thanks @skyclouds2001 - taking a look shortly

files/en-us/web/api/ui_events/index.md

bsmth · 2023-11-17T09:28:46Z

Searching through other content brings up these:

content/files/en-us/web/svg/attribute/end/index.md

Lines 70 to 71 in 00a2f5f

    
           - {{domxref("Element/beforeinput_event", "beforeinput")}} 
        
           - {{domxref("Element/input_event", "input")}}

Could we fix it in this PR, also? Those are the last ones I can find in other docs.

skyclouds2001 · 2023-11-17T15:41:04Z

honestly, I check the standard again, and notice that other event types in UI Events spec that say its target can be element, their documentations are written in Element, not HTMLElement

I check these events via event handle property (like oninput), they are available on Window, Document, HTMLElement, SVGElement and MathMLElement, but not available on Element

reference to Touch Events and Pointer Events, their event property handler are defined in GlobalEventHandlers mixin, which expose methods to Window, Document, HTMLElement, SVGElement and MathMLElement

also reference to TypeScript DOM definition file, which defines the GlobalEventHandlers interface reflecting the GlobalEventHandlers mixin in standard

so I guess a better solution is to move input event and beforeinput event from HTMLElement to Element

bsmth · 2023-11-27T11:54:21Z

a better solution is to move input event and beforeinput event from Element from HTMLElement

From the spec:

Trusted Targets Element (specifically: control types such as HTMLInputElement, etc.) or any Element with contenteditable attribute enabled

This makes sense to me. Note that if we move, it will need to also be moved in BCD:

@queengooborg any thoughts on this?

queengooborg · 2023-12-09T08:54:49Z

BCD places events based upon where the events are defined in the spec, rather than the event handlers -- so, this change makes sense to me, yes.
Related: mdn/browser-compat-data#19595

github-actions · 2023-12-24T06:52:29Z

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions · 2023-12-25T07:24:07Z

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions · 2024-01-02T05:45:46Z

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions · 2024-01-04T20:11:45Z

This pull request has merge conflicts that must be resolved before it can be merged.

bsmth · 2024-01-08T11:46:50Z

Looking great, and I see the corresponding BCD is done, so I think we can merge shortly. Is it correct to say there are some minor leftovers of (HTMLElement/input_event & HTMLElement/beforeinput) in the following two docs:

/files/en-us/web/api/document/execcommand/index.md (link)
- [`beforeinput`](/en-US/docs/Web/API/HTMLElement/beforeinput_event) and [`input`](/en-US/docs/Web/API/HTMLElement/input_event):
/files/en-us/web/api/element/beforeinput_event/index.md
- ... in contrast to the {{domxref("HTMLElement/input_event", "input")}} event,

bsmth

After the BCD has landed in mdn/browser-compat-data#21640, leaving +1 with some comments for flaws that we can fix here. We can merge after cleaning these up if you like

Thank you!

skyclouds2001 · 2024-01-08T12:10:14Z

HTMLElement/beforeinput_event

fixed!

bsmth · 2024-01-08T13:33:16Z

Looking great, let's merge 🚢

ref: mdn/content#30288

* zh-cn: sync translated content * move beforeinput event and input event from HTMLElement to Element ref: mdn/content#30288 * Remove mobile guides and redirect to responsive design guide ref: mdn/content#31540 --------- Co-authored-by: Allo <yin199909@aliyun.com>

…ment` (mdn#30288) * fix link * add * revert· * move files * update link * HTMLElement/input_event to Element/input_event * update * fix links --------- Co-authored-by: Brian Thomas Smith <brian@smith.berlin>

fix link

5702e33

skyclouds2001 requested a review from a team as a code owner November 15, 2023 09:47

skyclouds2001 requested review from wbamberg and removed request for a team November 15, 2023 09:47

github-actions bot added the Content:WebAPI Web API docs label Nov 15, 2023

skyclouds2001 changed the title ~~fix link~~ fix link in UI events Nov 15, 2023

add

2ed20fd

skyclouds2001 requested a review from a team as a code owner November 15, 2023 10:32

skyclouds2001 requested review from bsmth and removed request for a team November 15, 2023 10:32

bsmth reviewed Nov 17, 2023

View reviewed changes

files/en-us/web/api/ui_events/index.md Outdated Show resolved Hide resolved

skyclouds2001 added 3 commits November 20, 2023 03:30

revert·

57fc1ce

move files

cf4f714

update link

1c16144

skyclouds2001 requested a review from a team as a code owner November 20, 2023 03:49

skyclouds2001 changed the title ~~fix link in UI events~~ move beforeinput event and input event from HTMLElement from Element Nov 20, 2023

skyclouds2001 changed the title ~~move beforeinput event and input event from HTMLElement from Element~~ move beforeinput event and input event from HTMLElement to Element Nov 20, 2023

wbamberg removed their request for review November 22, 2023 00:17

skyclouds2001 requested a review from bsmth November 27, 2023 09:15

bsmth added the needs BCD update label Nov 28, 2023

Merge branch 'main' into ui-events

9a70774

This was referenced Dec 15, 2023

Add link to cancel event to HTMLInputElement page #30946

Closed

Move beforeinput and input event from HTMLElement to Element mdn/browser-compat-data#21640

Merged

github-actions bot added the merge conflicts 🚧 label Dec 17, 2023

github-actions bot added the merge conflicts 🚧 label Dec 24, 2023

Merge branch 'main' into ui-events

4a8fa5a

github-actions bot removed merge conflicts 🚧 Content:Events Events docs labels Dec 24, 2023

github-actions bot added the merge conflicts 🚧 label Dec 25, 2023

Merge branch 'main' into ui-events

c2ea168

github-actions bot removed the merge conflicts 🚧 label Dec 25, 2023

github-actions bot added the merge conflicts 🚧 label Jan 2, 2024

chrisdavidmills removed their request for review January 2, 2024 16:12

Merge branch 'main' into ui-events

38818d7

github-actions bot added merge conflicts 🚧 and removed merge conflicts 🚧 labels Jan 3, 2024

Merge branch 'main' into ui-events

d728c9f

github-actions bot removed the merge conflicts 🚧 label Jan 5, 2024

Merge branch 'main' into ui-events

73f2ab7

bsmth approved these changes Jan 8, 2024

View reviewed changes

fix links

0df5fe4

bsmth merged commit 72ca3d7 into mdn:main Jan 8, 2024
8 checks passed

skyclouds2001 deleted the ui-events branch January 8, 2024 14:30

yin1999 added a commit to mdn/translated-content that referenced this pull request Jan 9, 2024

move beforeinput event and input event from HTMLElement to Element

259b034

ref: mdn/content#30288

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move `beforeinput` event and `input` event from `HTMLElement` to `Element` #30288

move `beforeinput` event and `input` event from `HTMLElement` to `Element` #30288

skyclouds2001 commented Nov 15, 2023 •

edited

github-actions bot commented Nov 15, 2023 •

edited

bsmth commented Nov 17, 2023

bsmth commented Nov 17, 2023

skyclouds2001 commented Nov 17, 2023 •

edited

bsmth commented Nov 27, 2023

queengooborg commented Dec 9, 2023 •

edited

github-actions bot commented Dec 24, 2023

github-actions bot commented Dec 25, 2023

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 4, 2024

bsmth commented Jan 8, 2024

bsmth left a comment

skyclouds2001 commented Jan 8, 2024

bsmth commented Jan 8, 2024

move beforeinput event and input event from HTMLElement to Element #30288

move beforeinput event and input event from HTMLElement to Element #30288

Conversation

skyclouds2001 commented Nov 15, 2023 • edited

Description

Motivation

Additional details

Related issues and pull requests

github-actions bot commented Nov 15, 2023 • edited

bsmth commented Nov 17, 2023

bsmth commented Nov 17, 2023

skyclouds2001 commented Nov 17, 2023 • edited

bsmth commented Nov 27, 2023

queengooborg commented Dec 9, 2023 • edited

github-actions bot commented Dec 24, 2023

github-actions bot commented Dec 25, 2023

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 4, 2024

bsmth commented Jan 8, 2024

bsmth left a comment

Choose a reason for hiding this comment

skyclouds2001 commented Jan 8, 2024

bsmth commented Jan 8, 2024

move `beforeinput` event and `input` event from `HTMLElement` to `Element` #30288

move `beforeinput` event and `input` event from `HTMLElement` to `Element` #30288

skyclouds2001 commented Nov 15, 2023 •

edited

github-actions bot commented Nov 15, 2023 •

edited

skyclouds2001 commented Nov 17, 2023 •

edited

queengooborg commented Dec 9, 2023 •

edited