Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct instructions for checking Render Mode #7354

Merged
merged 3 commits into from Jul 28, 2021
Merged

Correct instructions for checking Render Mode #7354

merged 3 commits into from Jul 28, 2021

Conversation

qubist
Copy link
Contributor

@qubist qubist commented Jul 27, 2021

What was wrong/why is this fix needed? (quick summary only)

I couldn't find "View Page Info" anywhere in the context menu for Firefox (90.0.2 (64-bit), macOS). Instead I found "Page Info" under "Tools" which brings up the dialogue they're talking about here.

Issue number (if there is an associated issue)

N/A

Anything else that could help us review it

@qubist qubist requested a review from a team as a code owner July 27, 2021 20:01
@qubist qubist requested review from ericwbailey and removed request for a team July 27, 2021 20:01
@Ryuno-Ki
Copy link
Collaborator

@Ryuno-Ki
Copy link
Collaborator

view-page-info

I'm using Firefox on Linux and can see the option in the context menu (see above).

Copy link
Collaborator

@Ryuno-Ki Ryuno-Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work for you?

@@ -46,7 +46,7 @@ <h3 id="XHTML">XHTML</h3>

<h2 id="How_do_I_see_which_mode_is_used">How do I see which mode is used?</h2>

<p>In Firefox, select <em>View Page Info</em> from the context menu, and look for <em>Render Mode</em>.</p>
<p>In Firefox, select <em>Page Info</em> from the <em>Tools</em> context menu, and look for <em>Render Mode</em>.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>In Firefox, select <em>Page Info</em> from the <em>Tools</em> context menu, and look for <em>Render Mode</em>.</p>
<p>In Firefox, select <em>Page Info</em> from the <em>Tools</em> menu bar, and look for <em>Render Mode</em>.</p>

Can we agree on the middle ground?
Hitting Alt brings up the menu bar for me (on Linux - resp. Command on macOS?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I got confused about what "context menu" was when I didn't see "View Page Info" there:

Screen Shot 2021-07-27 at 4 37 14 PM (Firefox on macOS)

Since "Page Info" is in the menu bar in both Linux and macOS, I think your suggested change is a great way to go. on macOS, the menu bar is shown without having to bring it up.

(By the way, this is the resource I used to find the Page Info window when these instructions didn't work for me: https://support.mozilla.org/en-US/kb/firefox-page-info-window)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you've found it!
I actually hopped over to support.mozilla.org in hope of finding a link to send you. We should include it!
May I ask you for one more round of adjustment to sneak that link in?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/HTML/Quirks_Mode_and_Standards_Mode
Title: Quirks Mode and Standards Mode
on GitHub
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/HTML
    • Is currently http:// but can become https://
    • Can't resolve /en-US/docs/XHTML
    • Can't resolve /en-US/docs/XHTML#Support

External URLs

URL: /en-US/docs/Web/HTML/Quirks_Mode_and_Standards_Mode
Title: Quirks Mode and Standards Mode
on GitHub

(this comment was updated 2021-07-28 19:15:38.918785)

Co-authored-by: André Jaenisch <Ryuno-Ki@users.noreply.github.com>
@qubist qubist requested a review from Ryuno-Ki July 27, 2021 20:44
@qubist
Copy link
Contributor Author

qubist commented Jul 28, 2021

How's that look? I'm not familiar with the format of the rest of this documentation, so if the change doesn't look fitting, please let me know!

Copy link
Collaborator

@Ryuno-Ki Ryuno-Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this!

@Ryuno-Ki Ryuno-Ki merged commit 07e5b08 into mdn:main Jul 28, 2021
@Ryuno-Ki
Copy link
Collaborator

@qubist Thank you so much for being patient enough.
Congratulations on getting your first PR merged! 🥳
Welcome aboard!

@qubist qubist deleted the patch-1 branch July 29, 2021 03:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants