New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): update README to reference MDN docs #1

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@100stacks
Copy link
Contributor

100stacks commented Oct 30, 2018

Submitting PR:

  • reference MDN Guide on cross-browser testing
  • reference MDN automated testing tutorial
  • Additionally, the wiki is referencing a Mozilla/Sauce Labs extended trial offer, which is no longer available.

Thank you Mozilla for all you do for the global community!!! 馃帀

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Oct 30, 2018

Thanks for the contribution, @100stacks . I've removed the references to the sauce labs trial from the Wiki too, good call.

Your update here looks mostly fine; the only thing I'd like to see changed is the way you reference the MDN Web Docs pages. For a start, the title has changed, and the grammar could do with a little tweak. Can you change both of the references to use the following format?

[Guide to Cross Browser Testing](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing) on MDN Web Docs

?

Thanks again.

@100stacks

This comment has been minimized.

Copy link
Contributor

100stacks commented Oct 30, 2018

Sounds great @chrisdavidmills! Your recommendations definitely flow better.

I'll push up the changes.

Thanks!

@100stacks 100stacks force-pushed the 100stacks:master branch 4 times, most recently from 3ebc5fc to 30d95ac Oct 30, 2018

@100stacks

This comment has been minimized.

Copy link
Contributor

100stacks commented Oct 30, 2018

Hi @chrisdavidmills, I worked on the wording for the sections.

Also, the new section titles are a little longer. I can keep the heading size as is, or use a <h2> or <h3> if you prefer.

Thanks again 馃憤

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Oct 31, 2018

@100stacks thanks James! Yeah, the two sub-headings should really be <h2>s, to create a proper heading hierarchy. Can you change them? after that I'll merge. Cheers!

docs(README): update README to reference MDN Web Docs
* reference MDN Module on Cross Browser Testing
* reference MDN Guide for Introduction to Automated Testing

@100stacks 100stacks force-pushed the 100stacks:master branch from 30d95ac to 4c5087b Oct 31, 2018

@100stacks

This comment has been minimized.

Copy link
Contributor

100stacks commented Oct 31, 2018

Ok cool, @chrisdavidmills! I made the two sub-headings <h2> ...anything else please let me know.

Appreciate you taking the time!!!

@chrisdavidmills chrisdavidmills merged commit 6c647b7 into mdn:master Nov 1, 2018

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 1, 2018

Great! Merged.

Thanks for the contribution; we really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment