New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning about Firefox 33 from @counter-style demo #10

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@oslego
Contributor

oslego commented Oct 5, 2018

Removes outdated warning about CSS @counter-style being supported only on Firefox 33.

@chrisdavidmills

This comment has been minimized.

Contributor

chrisdavidmills commented Oct 5, 2018

Hi Razvan! The change makes sense, if it is supported in more places now, but this doesn't appear to be the case. I've just tested it on Firefox, Chrome, Opera, Safari, and Edge, and it still doesn't appear to work anywhere except Firefox.

Have you got evidence to the contrary?

@oslego

This comment has been minimized.

Contributor

oslego commented Oct 5, 2018

My reason for removing the warning was that Firefox 33 is outdated, not that the feature has widespread support.

Feel free to accept or reject the PR.

My thinking is that there are places better suited to inform users of browser support: caniuse.com/#search=counter-style or the support matrix on the @counter-style MDN page which links to this demo. I doubt the support warning in this demo file will be kept up to date, while other sources will be.

@chrisdavidmills

This comment has been minimized.

Contributor

chrisdavidmills commented Oct 5, 2018

OK, I get your reasoning, and think it makes sense. Thanks for the explanation. r+

@chrisdavidmills chrisdavidmills merged commit 1347cdc into mdn:master Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment