New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add justify-self CSS property #184

Merged
merged 4 commits into from Apr 5, 2018

Conversation

Projects
None yet
4 participants
@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Feb 28, 2018

Build failure:

  Style – Error on line #4679
    Actual:       "appliesto": ["gridItemsAndBoxesWithinGridContainer", "boxElements"],
    Expected:     "appliesto": [
  JSON Schema – 2 error(s)
    item['justify-self'].groups[0] should be equal to one of the allowed values
    item['justify-self'].appliesto should be equal to one of the allowed values

I thought appliesto can take an array? Otherwise, I am not sure what to put there. Can anyone help?

@lahmatiy

This comment has been minimized.

Contributor

lahmatiy commented Feb 28, 2018

Just replace it with a single string blockLevelBoxesAndAbsolutelyPositionedBoxesAndGridItems (according to spec draft), add this value to css/properties.schema.json (at applyto enum) and add to l10n/css.json this section:

"blockLevelBoxesAndAbsolutelyPositionedBoxesAndGridItems": {
    "en-US": "block-level boxes, absolutely-positioned boxes, and grid items"
}
@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Feb 28, 2018

CSS Box Alignment group is added in #185

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Feb 28, 2018

Feedback from code review is applied

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Apr 4, 2018

@lahmatiy any luck in re-reviewing it?

@frenic

This comment has been minimized.

Contributor

frenic commented Apr 4, 2018

A friendly reminder to fix the merge conflict due to #184 being merged. Lets hope this can be merged anytime soon.

@wbamberg

Looks good to me!

@wbamberg wbamberg merged commit 9513169 into mdn:master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pkuczynski pkuczynski deleted the pkuczynski:justify-self branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment