New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add justify-items CSS property #185

Merged
merged 3 commits into from Apr 4, 2018

Conversation

Projects
None yet
4 participants
@lahmatiy

This comment has been minimized.

Contributor

lahmatiy commented Feb 28, 2018

Looks like CSS Box Alignment Module is a new group. It should be renamed to CSS Box Alignment and added to css/definitions.json

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Feb 28, 2018

Sure! Done...

@wbamberg

Please correct me if I'm wrong, but it looks like the syntax for this property has changed in the (too long) that this PR has been open.

@@ -4667,6 +4667,21 @@
"order": "uniqueOrder",
"status": "standard"
},
"justify-items": {
"syntax": "normal | stretch | <baseline-position> | [ <overflow-position>? <self-position> ] | [ legacy || [ left | right | center ] ]",

This comment has been minimized.

@wbamberg

wbamberg Apr 4, 2018

Member

It looks as if this has changed: https://drafts.csswg.org/css-align-3/#propdef-justify-items. If you agree, and can update it, I'll merge this PR.

@frenic frenic referenced this pull request Apr 4, 2018

Closed

Missing justify-self property #19

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Apr 4, 2018

@wbamberg I updated the PR. Is it good now? It's annoying that it's stuck for so long. I was planning to add more stuff, but my PR has not been merged so my motivation floored.

@wbamberg

This comment has been minimized.

Member

wbamberg commented Apr 4, 2018

It's annoying that it's stuck for so long.

I know, I'm sorry about that. Thanks for your contribution. It looks good to me now, and since it already got the 👍 from lahmatiy, let's merge this.

@wbamberg wbamberg merged commit acb3801 into mdn:master Apr 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pkuczynski pkuczynski deleted the pkuczynski:justify-items branch Apr 4, 2018

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Apr 4, 2018

No worries, we all busy :)

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Apr 4, 2018

So now time for #184 :)

@frenic

This comment has been minimized.

Contributor

frenic commented Apr 4, 2018

I'm thankful too @pkuczynski for all your PRs. I would love to see more from you 🙏

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Apr 5, 2018

We will see @frenic ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment