New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing items to selectors.json. #198

Merged
merged 3 commits into from Apr 10, 2018

Conversation

Projects
None yet
2 participants
@jpmedley
Contributor

jpmedley commented Apr 9, 2018

Makes sure all the items listed in pseudo-classes have an entry in selectors.json.

@wbamberg

Thanks @jpmedley . I had some questions about the values you've added for "syntax".

@@ -191,6 +191,14 @@
],
"status": "standard"
},
":focus-visible": {
"syntax": ":focus",

This comment has been minimized.

@wbamberg

wbamberg Apr 10, 2018

Member

Should this be :focus-visible?

@@ -199,6 +207,22 @@
],
"status": "experimental"
},
":host": {
"syntax": ":hover",

This comment has been minimized.

@wbamberg

wbamberg Apr 10, 2018

Member

Should this be :host?

"status": "experimental"
},
":host-context": {
"syntax": ":hover",

This comment has been minimized.

@wbamberg

wbamberg Apr 10, 2018

Member

Should this be :host-context?

@jpmedley

This comment has been minimized.

Contributor

jpmedley commented Apr 10, 2018

PTAL

@@ -192,7 +192,7 @@
"status": "standard"
},
":focus-visible": {
"syntax": ":focus",
"syntax": "focus-visible",

This comment has been minimized.

@wbamberg

wbamberg Apr 10, 2018

Member

sorry @jpmedley , my initial feedback was wrong, it should be :focus-visible AFAICT

@wbamberg

Sorry @jpmedley , my initial comment on :focus-visible was wrong, the syntax should be :focus-visible AFAICT

@wbamberg

Thanks @jpmedley !

@wbamberg wbamberg merged commit 60dd465 into mdn:master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jpmedley jpmedley deleted the jpmedley:selectors branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment