New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font-weight syntax for CSS Fonts 4 #234

Merged
merged 2 commits into from May 30, 2018

Conversation

Projects
None yet
3 participants
@wbamberg
Member

wbamberg commented May 24, 2018

This updates the syntax of font-weight for the CSS Fonts Level 4 spec: https://drafts.csswg.org/css-fonts-4/#font-weight-prop

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1436048

I've tested it using csssyntax.ejs on a local Kuma, and it did what I expected.

@@ -227,6 +227,9 @@
"font-variant-css21": {
"syntax": "[ normal | small-caps ]"
},
"font-weight-absolute": {
"syntax": "[normal | bold | <number>]"

This comment has been minimized.

@frenic

frenic May 24, 2018

Contributor

Aren't syntaxes already grouped or have I misunderstood something? I mean it doesn't have any multiplier or anything like that.

This comment has been minimized.

@wbamberg

wbamberg May 24, 2018

Member

I think you are right. I just copied it from the spec, but it looks like this is an instance of what @lahmatiy was talking about in #230.

@wbamberg wbamberg requested a review from Elchi3 May 29, 2018

@Elchi3

Elchi3 approved these changes May 30, 2018

LGTM 👍

@Elchi3 Elchi3 merged commit 70a6143 into mdn:master May 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment