New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -webkit-overflow-scrolling inheritance #331

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@timothy003
Copy link
Contributor

timothy003 commented Nov 29, 2018

This corrects -webkit-overflow-scrolling to be an inherited property. Setting -webkit-overflow-scrolling: touch on an element causes it and its descendants to create stacking contexts, which affects the behavior of z-index.

https://bugs.chromium.org/p/chromium/issues/detail?id=128325#c23

Fix -webkit-overflow-scrolling inheritance
This corrects -webkit-overflow-scrolling to be an inherited property. Setting -webkit-overflow-scrolling: touch on an element causes it and its descendants to create stacking contexts, which affects the behavior of z-index.

https://bugs.chromium.org/p/chromium/issues/detail?id=128325#c23
@timothy003

This comment has been minimized.

Copy link
Contributor

timothy003 commented Nov 29, 2018

Should appliesto also be changed to "allElements" to reflect its behavior on non-scrolling boxes?

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 30, 2018

So, I agree with you about inheritance — it sounds like at least some significant behavior is inherited.

As for "appliesto", I think it'd make more sense to leave it as is. It doesn't really make sense to apply this to a non-scrolling element? What behavior does it exhibit when applied directly to a non-scrolling element?

@timothy003

This comment has been minimized.

Copy link
Contributor

timothy003 commented Nov 30, 2018

According to this discussion, it used to create a stacking context even for non-scrolling elements, but after testing the fiddle on iOS 12.1, this no longer appears to be the case. So, I assume that's been fixed and it now only creates a stacking context for scrollable elements.

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 30, 2018

OK, cool. I think this is good as is then...merging.

Thanks for the contribution!

@chrisdavidmills chrisdavidmills merged commit a21219f into mdn:master Nov 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment