New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added server-sent-events/README.md #20

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
2 participants
@duzun
Contributor

duzun commented May 10, 2018

I've spent some time trying to make this example work with no luck, and in the end, I've found that fastcgi_buffering was causing troubles.
I think it is worth mentioning this small fact.

@@ -0,0 +1,3 @@
Note about runing this example through **NGINX**:

This comment has been minimized.

@chrisdavidmills

chrisdavidmills May 11, 2018

Contributor

Thanks for the addition! Couple of change requests:

  • Typo - runing -> running
  • Can you turn this line into a heading?
Added server-sent-events/README.md
I've spent some time trying to make this example work with no luck, and in the end, I've found that `fastcgi_buffering` was causing troubles.
I think it is worth mentioning this small fact.
@duzun

This comment has been minimized.

Contributor

duzun commented May 16, 2018

@chrisdavidmills done.

Is it worth adding while(!connection_aborted()) ... for this example, what do you think?

@chrisdavidmills

This comment has been minimized.

Contributor

chrisdavidmills commented May 16, 2018

Thanks! I'll merge this now. I think it might be worth considering adding a conditional check, yes. Do you fancy handling that in a separate PR?

@chrisdavidmills chrisdavidmills merged commit aa1e181 into mdn:master May 16, 2018

@duzun

This comment has been minimized.

Contributor

duzun commented May 16, 2018

Cool!

@duzun duzun deleted the duzun:patch-1 branch Jul 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment