New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chroma keying #29

Merged
merged 5 commits into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@wbamberg
Copy link
Member

wbamberg commented Nov 6, 2018

This migrates the live example from developer.mozilla.org/samples to GitHub, in an attempt to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1501297, specifically as Julien suggests in comment 3: https://bugzilla.mozilla.org/show_bug.cgi?id=1501297#c3..

It adds "canvas/chroma-keying", that contains an HTML file and a JS file corresponding to the files discussed in https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Manipulating_video_using_canvas, as well as the media files used in the example.

I've tested this at https://wbamberg.github.io/dom-examples/canvas/chroma-keying/ and it seems to work fine.

@chrisdavidmills
Copy link
Contributor

chrisdavidmills left a comment

This looks basically fine. The only changes I'd possibly make are:

  1. Don't use an event handler attribute in the HTML; turn this into an addEventListener call in the JS file.
  2. Maybe provide an MP4 video, for better cross browser compatibility?
@wbamberg

This comment has been minimized.

Copy link
Member

wbamberg commented Nov 15, 2018

I've updated the PR, and also the version at https://wbamberg.github.io/dom-examples/canvas/chroma-keying/, so you can see it working. And now it works in Safari too :).

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 15, 2018

Great stuff. But now it no longer seems to work in Fx ;-)

@wbamberg

This comment has been minimized.

Copy link
Member

wbamberg commented Nov 15, 2018

It works for me in Firefox, at https://wbamberg.github.io/dom-examples/canvas/chroma-keying/:

chroma-keying

Do you see any errors in the console?

@chrisdavidmills
Copy link
Contributor

chrisdavidmills left a comment

That is bizarre — I swear it wasn't working before; now it's working fine!

OK, approving, looks great Will.

@wbamberg

This comment has been minimized.

Copy link
Member

wbamberg commented Nov 15, 2018

Thanks @chrisdavidmills ! I'm not a collaborator on this repo, so I can't merge it, so could you do that too? Or make me a collaborator of course :).

@chrisdavidmills chrisdavidmills merged commit f515fd4 into mdn:master Nov 15, 2018

@chrisdavidmills

This comment has been minimized.

Copy link
Contributor

chrisdavidmills commented Nov 15, 2018

How about both? I'll send you an invite in a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment