New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth branch #54

Merged
merged 12 commits into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@caglarturali

caglarturali commented Oct 26, 2018

Hi folks. I've implemented user authentication and -quite trivial- authorization functionality for our awesome locallibrary project :) At first, I was thinking about documenting it but honestly, it's not gonna happen any time soon. So, I decided to create a new branch for it. I think it would be nice to have such a functionality even though we've not documented it yet. You can check out the live version of auth branch here. And if you want to document it, go for it, you're more than welcome.

By the way, I just noticed that this branch will end up merged into the master branch if you approve it. And that would be controversial. So, I can change base branch of pull request if you create a new branch preferably named auth.

@hamishwillee

This comment has been minimized.

Collaborator

hamishwillee commented Oct 26, 2018

Ignore my comment in #55 :-)

Thanks very much for this - always great to get new features and improvements.

Can you push this to this repo? Ie if this is upstream repo do git push upstream auth (it may be you are saying you don't have the rights?

I plan to look at this tutorial again in the next couple of months and when I do that I will take the time to decide whether/how we should merge the content and add documentation. It might be we do just as you have - create a link from readme.

@caglarturali

This comment has been minimized.

caglarturali commented Oct 26, 2018

Nope, I can't push to this repo. It responds with permission denied message.

@hamishwillee

This comment has been minimized.

Collaborator

hamishwillee commented Oct 26, 2018

Thanks. OK, I have created the branch.

@caglarturali caglarturali changed the base branch from master to auth Oct 26, 2018

@caglarturali

This comment has been minimized.

caglarturali commented Oct 26, 2018

Ok, I've changed base branch from master to auth. It should be good to go now.

@hamishwillee hamishwillee merged commit 074afbb into mdn:auth Oct 26, 2018

@hamishwillee

This comment has been minimized.

Collaborator

hamishwillee commented Oct 26, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment