Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1483072: make awscli profile optional #1137

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@escattone
Copy link
Member

commented Sep 7, 2018

The MozMEAO-owned Jenkins service uses locally-installed AWS credentials within the mdninteractive profile in order to perform its aws s3 sync command, but the new IT-owned Jenkins service has moved to the AWS-recommended approach of associating IAM roles with EC2 instances (see https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_use_switch-role-ec2.html). This PR allows us to satisfy both approaches during this interim period until we make the cutover to the IT-owned services.

This has been successfully tested for both the new IT-owned and MozMEAO-owned Jenkins services.

@jwhitlock jwhitlock merged commit 6d21d18 into mdn:master Sep 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (schalkneethling) No manifest changes detected

@escattone escattone deleted the escattone:optional-awscli-profile-1483072 branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.