Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating picture example to work better on small screens #1149

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@ollelauribostrom
Copy link
Contributor

commented Sep 19, 2018

As discussed in #1085.

Updated the media attribute in the <picture> example to make it work better on smaller screens. 馃檪

@welcome

This comment has been minimized.

Copy link

commented Sep 19, 2018

馃挅 Thanks for opening this pull request! 馃挅
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.
@wbamberg
Copy link
Member

left a comment

Awesome, thanks @ollelauribostrom ! :)

@wbamberg wbamberg merged commit c06ce9b into mdn:master Sep 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (schalkneethling) No manifest changes detected
@welcome

This comment has been minimized.

Copy link

commented Sep 19, 2018

Congrats on merging your first pull request! 馃帀馃帀馃帀

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request Oct 16, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Rename file as "*" is not a valid character in Windows file name (mdn#1151)
  Updating picture example to work better on small screens (mdn#1149)
  Fix incorrect label selector (mdn#1147)
  Each radio button in the group should have distinct `value` attribute (mdn#1141)
  Add example for Object.fromEntries (mdn#1127)
  Added more helpful technique for accessing promise (mdn#1124)
  Editor config fix (mdn#1143)

@ollelauribostrom ollelauribostrom deleted the ollelauribostrom:fix-picture-example branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.