Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 948422: increase colour contract of comments in code examples #1159

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@ninjanails
Copy link
Contributor

commented Sep 24, 2018

Update colour contrast of commented code
The current contrast is 3.49:1, which is below the minimum 4.5 ratio needed to meet the WCAG AA guidelines. The proposed change increases the contrast to 4.52:1

Example of how new contract looks
image

also see bug https://bugzilla.mozilla.org/show_bug.cgi?id=948422

@welcome

This comment has been minimized.

Copy link

commented Sep 24, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.
@schalkneethling
Copy link
Collaborator

left a comment

r+ Thanks @ninjanails 🎉

@schalkneethling schalkneethling merged commit 48e3709 into mdn:master Sep 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (schalkneethling) No manifest changes detected
@welcome

This comment has been minimized.

Copy link

commented Sep 25, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.