New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use template strings to improve readability #1187

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@Flying-Toast
Contributor

Flying-Toast commented Oct 17, 2018

No description provided.

@welcome

This comment has been minimized.

welcome bot commented Oct 17, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.
@wbamberg

Looks good to me, thanks @Flying-Toast !

@wbamberg wbamberg merged commit 7a3a5d6 into mdn:master Oct 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 17, 2018

Congrats on merging your first pull request! 🎉🎉🎉

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request Oct 29, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  chore(repo) - Use consistent file naming across media assets (mdn#1191)
  chore(community) - Add @ShadowMitia as contributor (mdn#1203)
  Add "attribute-" prefix to HTML attribute examples. (mdn#1189)
  Js example output value changed  (mdn#1182)
  chore(deps): update dependency all-contributors-cli to v5.4.1 (mdn#1188)
  Issue#1192 links to media files broken (mdn#1197)
  Fix bug String.normalize live example (mdn#1193)
  chore(community) - Add @Flying-Toast as contributor (mdn#1195)
  Update html guidelines (mdn#1184)
  Use template strings to improve readability (mdn#1187)
  chore(community): add @TremaineNeethling as contributor (mdn#1183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment