New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "attribute-" prefix to HTML attribute examples. #1189

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
2 participants
@ShadowMitia
Contributor

ShadowMitia commented Oct 18, 2018

Should close #1065.

@welcome

This comment has been minimized.

welcome bot commented Oct 18, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.
@schalkneethling

Couple of changes, but this looks good. Thanks for the contribution @ShadowMitia 🎉

@ShadowMitia

This comment has been minimized.

Contributor

ShadowMitia commented Oct 27, 2018

I've reused the css file as asked. Guess I was too busy renaming that I didn't notice I actually added that file!

@schalkneethling

Thanks @ShadowMitia r+ 🎉

@schalkneethling schalkneethling merged commit 6b0d3ba into mdn:master Oct 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (schalkneethling) No new issues
Details
@welcome

This comment has been minimized.

welcome bot commented Oct 29, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@ShadowMitia

This comment has been minimized.

Contributor

ShadowMitia commented Oct 29, 2018

Glad I could help!

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request Oct 29, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  chore(repo) - Use consistent file naming across media assets (mdn#1191)
  chore(community) - Add @ShadowMitia as contributor (mdn#1203)
  Add "attribute-" prefix to HTML attribute examples. (mdn#1189)
  Js example output value changed  (mdn#1182)
  chore(deps): update dependency all-contributors-cli to v5.4.1 (mdn#1188)
  Issue#1192 links to media files broken (mdn#1197)
  Fix bug String.normalize live example (mdn#1193)
  chore(community) - Add @Flying-Toast as contributor (mdn#1195)
  Update html guidelines (mdn#1184)
  Use template strings to improve readability (mdn#1187)
  chore(community): add @TremaineNeethling as contributor (mdn#1183)

@wbamberg wbamberg referenced this pull request Nov 5, 2018

Merged

Update global attributes #1224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment