New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with the Jenkins build step #1229

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@escattone
Copy link
Member

escattone commented Nov 8, 2018

This PR resolves #1211 such that hopefully its root cause never happens again:

  • remove the node_modules directory prior to calling npm install in order to prevent install failures due to conflicts between the contents of the node_modules directory leftover from the previous install and the current install
  • bin/build.sh failures are no longer silent

This has been tested on Jenkins using a special test branch (ryan-test), both for the case of a successful build as well as for the case of a build failure.

fix issues with the Jenkins build step
* remove the local "node_modules" directory
  prior to calling "npm install" in order to
  prevent install failures due to conflicts
  between the contents of the "node_modules"
  directory leftover from the previous install
  and the current install
* "bin/build.sh" failures are no longer silent
@metadave
Copy link
Member

metadave left a comment

👍

@escattone escattone merged commit 0f64bc2 into mdn:master Nov 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (schalkneethling) No new issues
Details

@escattone escattone deleted the escattone:ryan-fix-jenkins-build-1211 branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment